-
Notifications
You must be signed in to change notification settings - Fork 4.5k
workflows+gradle: capture and run ML tests that require non self-hosted environment on ubuntu-latest
#35585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows+gradle: capture and run ML tests that require non self-hosted environment on ubuntu-latest
#35585
Conversation
ubuntu-latest
ubuntu-latestubuntu-latest
|
cc @damccorm for thoughts and feedback on this approach 🙏 PS: |
|
Assigning reviewers: R: @liferoad for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - the approach looks good, just had some minor doc suggestions
Co-authored-by: Danny McCormick <[email protected]>
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll merge after checks complete
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Handle ML tests that can't run on self-hosted runners mainly due to Docker-in-Docker environment limitations or other operational constraints by:
require_non_self_hostedpytest markerrequire_non_self_hostedusingnonSelfHostedIntegrationTestgradle tasknonSelfHostedIntegrationTestcapture task to Postcommit Itests to runbeam_PostCommit_Pythonandbeam_PreCommit_Python_MLto conditionally run test cases that require non-self hosted environment if any onubuntu-latestGitHub hosted runnerWe could follow an incremental approach here for running tests that require non self-hosted environmnet, targeting specific workflows as needed. For example, the current implementation addresses the dependent PR related to Milvus integration, which requires a non-self-hosted environment for ML testing.
Dependency for #35577
Motivation and Context
Follow-up on the discussion here #35216 (comment).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.UpdateCHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.