ARROW-11375: [Rust] Fix deprecation warning in clippy#9314
ARROW-11375: [Rust] Fix deprecation warning in clippy#9314jorgecarleitao wants to merge 1 commit intoapache:masterfrom jorgecarleitao:fix_masteer
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
Codecov Report
@@ Coverage Diff @@
## master #9314 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 215 215
Lines 52988 52988
=======================================
Hits 43392 43392
Misses 9596 9596 Continue to review full report at Codecov.
|
|
It seems like perhaps this is related to the release of criterion: https://crates.io/crates/criterion/0.3.4 (On Jan 24 2021) |
|
The |
alamb
left a comment
There was a problem hiding this comment.
Thanks for handling this @jorgecarleitao - ❤️
I think there is still some clippy errors (I can see them locally too when I run cargo update) but this PR fixes some of them so merging it in seems like a good idea to me.
I can take a crack at updating the error too later today if you don't get around to it.
|
It should be fixed now. :) |
|
|
nevi-me
left a comment
There was a problem hiding this comment.
we need not wait for Travis
|
I will file a JIRA ticket and merge this in |
Master and all PRs are failing with a deprecation warning in clippy. This fixes it. Closes #9314 from jorgecarleitao/fix_masteer Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Master and all PRs are failing with a deprecation warning in clippy. This fixes it. Closes apache#9314 from jorgecarleitao/fix_masteer Authored-by: Jorge C. Leitao <jorgecarleitao@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Master and all PRs are failing with a deprecation warning in clippy. This fixes it.