ARROW-11131: [Rust] Improve performance of bool_equal#9101
Closed
mqy wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-11131: [Rust] Improve performance of bool_equal#9101mqy wants to merge 1 commit intoapache:masterfrom
mqy wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9101 +/- ##
==========================================
+ Coverage 82.60% 82.66% +0.05%
==========================================
Files 204 204
Lines 50175 50327 +152
==========================================
+ Hits 41447 41602 +155
+ Misses 8728 8725 -3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows @jorgecarleitao 's great PR #8541, with the following changes:
lhsandrhshave zero null count.(0..len).all(|i| {...}.NOTE: there are other similar cases where
test_struct()failed when updated in this way.equal_bool_512andequal_bool_nulls_512.Benchmark comparing to arrow master: