ARROW-10914: [Rust] Refactor simd arithmetic kernels to use chunked iteration#8929
Closed
jhorstmann wants to merge 4 commits intoapache:masterfrom
Closed
ARROW-10914: [Rust] Refactor simd arithmetic kernels to use chunked iteration#8929jhorstmann wants to merge 4 commits intoapache:masterfrom
jhorstmann wants to merge 4 commits intoapache:masterfrom
Conversation
… and avoid out of bounds reads
Contributor
Author
|
I'm seeing bigger variations on the benchmark numbers between runs, the results below between current master and this pr are from one of the faster runs: |
jorgecarleitao
approved these changes
Dec 18, 2020
Member
jorgecarleitao
left a comment
There was a problem hiding this comment.
Thanks a lot, @jhorstmann !
I did not go through all the details of this PR, but what I read looks really good and makes the code much easier to read. So, 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should avoid out of bounds reads in those kernels and also removes some unsafe blocks. The performance actually seems to increase slightly, I will post the numbers later.
The division kernel looks a bit more complex now, but follows the same pattern as used in the simd aggregation functions, with two separate codepaths for the nullable/non-null cases.
The comparison kernels might also do some out of bounds reads, I will look at those in a separate ticket/PR.