Skip to content

ARROW-10803: Support R >= 3.3 and add CI#8833

Closed
nealrichardson wants to merge 14 commits intoapache:masterfrom
nealrichardson:old-r-versions
Closed

ARROW-10803: Support R >= 3.3 and add CI#8833
nealrichardson wants to merge 14 commits intoapache:masterfrom
nealrichardson:old-r-versions

Conversation

@nealrichardson
Copy link
Member

@nealrichardson nealrichardson commented Dec 4, 2020 •
edited
Loading

Includes fixes for compiling on R 3.4 and R 3.3, plus a crossbow job to build on old R versions

@nealrichardson
Copy link
Member Author

nealrichardson commented Dec 4, 2020

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

Revision: 502b3ea42b47f3fad17c6b472312c6983be214c6

Submitted crossbow builds: ursa-labs/crossbow @ actions-738

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Dec 4, 2020

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

Revision: fb1daad6e7d92872bf2b0e42b8a287e650426e4e

Submitted crossbow builds: ursa-labs/crossbow @ actions-739

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Dec 4, 2020

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

Revision: 991dd4ff6a96e6177f86b9b52e9da8077b82824c

Submitted crossbow builds: ursa-labs/crossbow @ actions-740

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Dec 4, 2020

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

Revision: 7f9ddde635ffcfe00a63e7899e6b98c2cfdd732c

Submitted crossbow builds: ursa-labs/crossbow @ actions-741

Task Status
test-r-versions Github Actions

@nealrichardson nealrichardson changed the title WIP [R] Nightly CI for older R versions WIP ARROW-10803: [R] Failure to compile on R 3.4 Dec 4, 2020
@nealrichardson
Copy link
Member Author

nealrichardson commented Jan 8, 2021

@github-actions crossbow submit test-r-versions

@nealrichardson
Copy link
Member Author

nealrichardson commented Jan 8, 2021

@romainfrancois I cherry-picked the relevant commits from #8650 over here

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Revision: 1e3b400c2cef7751fabc1e05c3b6bae8af67bc35

Submitted crossbow builds: ursa-labs/crossbow @ actions-846

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Jan 8, 2021

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

https://issues.apache.org/jira/browse/ARROW-10803

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Revision: bb88861b33a9e68c43f40203d59bd579f31f6ae3

Submitted crossbow builds: ursa-labs/crossbow @ actions-847

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Jan 8, 2021

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Revision: 1506415af3e1055716eeed814c2ec74eb02e6879

Submitted crossbow builds: ursa-labs/crossbow @ actions-854

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Jan 8, 2021

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Revision: 0962bb92cd6bc7fdda3b79d72b45044644eacb80

Submitted crossbow builds: ursa-labs/crossbow @ actions-856

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Jan 8, 2021

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Revision: 1eaeea704961edf0525811be74dc47aa62803ed3

Submitted crossbow builds: ursa-labs/crossbow @ actions-857

Task Status
test-r-versions Github Actions

@nealrichardson
Copy link
Member Author

nealrichardson commented Jan 9, 2021

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented Jan 9, 2021

Revision: 46faf210f04d68b0be9ee72a8b10fc3116f1a190

Submitted crossbow builds: ursa-labs/crossbow @ actions-858

Task Status
test-r-versions Github Actions

@nealrichardson nealrichardson changed the title WIP ARROW-10803: [R] Failure to compile on R 3.4 ARROW-10803: [R] Failure to compile on R 3.4 Jan 9, 2021
@nealrichardson nealrichardson changed the title ARROW-10803: [R] Failure to compile on R 3.4 ARROW-10803: Support R >= 3.3 and add CI Jan 9, 2021
jonkeane
jonkeane reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small note

r/configure
fi

# Test configuration
CXXCPP="`${R_HOME}/bin/R CMD config CXX11` -E"
Copy link
Member

@jonkeane jonkeane Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it hurt to have this in the if [TRUE] block to match what's in the else block?

Copy link
Member Author

@nealrichardson nealrichardson Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it succeeded, then it's already set. I'll add a comment.

@nealrichardson nealrichardson deleted the old-r-versions branch January 11, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkeane jonkeane jonkeane left review comments

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nealrichardson @jonkeane @romainfrancois