ARROW-10628: [Rust] flag clippy warnings as errors#8687
Closed
alamb wants to merge 5 commits intoapache:masterfrom
Closed
ARROW-10628: [Rust] flag clippy warnings as errors#8687alamb wants to merge 5 commits intoapache:masterfrom
alamb wants to merge 5 commits intoapache:masterfrom
Conversation
alamb
commented
Nov 16, 2020
|
|
||
| pushd ${source_dir}/arrow | ||
| cargo clippy -- -A clippy::redundant_field_names | ||
| cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names |
Contributor
Author
There was a problem hiding this comment.
The -D warnings means "disallow anything that clippy would warn against" and treat them as an error
alamb
commented
Nov 16, 2020
| } | ||
| } | ||
|
|
||
| #[allow(clippy::enum_variant_names)] |
Contributor
Author
There was a problem hiding this comment.
While clippy has some valid points with these warnings, I did not want to address them in this PR
Member
|
@alamb There was no issue 10636 on Jira, so I created one, assigned it to you, and assigned this PR to it. |
Contributor
Author
|
Thank you @jorgecarleitao ! |
Contributor
Author
|
FYI @nevi-me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We do currently run clippy (aka rust linter) on all PRs. However, the way we invoke clippy means that any clippy warnings introduced in PRs do not cause a CI failure
I believe the intended behavior is that we keep the arrow project "Clippy clean"
Changes
Example of this not working today
For example, this PR has clippy flag a warning and yet the test still passes (note the PR doesn't introduce the warning).
https://github.com/apache/arrow/runs/1408182529?check_suite_focus=true
Testing of this PR: