ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])#8628
ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])#8628maartenbreddels wants to merge 11 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
I accidentally forgot the +1 here, and everything worked. Does CI include valgrind, and should it pick this up?
There was a problem hiding this comment.
The +1 should not be necessary. This is the number of values appended, not the number of offsets.
|
Looking at the implementation of |
pitrou
left a comment
There was a problem hiding this comment.
Just a couple comments. Thank you for this PR!
There was a problem hiding this comment.
Instead of calling MayHaveNulls, just compute the null count and check it here.
|
@pitrou i think this is ready to go/review. |
…ng], scalar[string])
pitrou
left a comment
There was a problem hiding this comment.
+1, will merge. Thank you @maartenbreddels !
No description provided.