ARROW-10277: [C++] Support comparing scalars approximately#8438
Closed
liyafan82 wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-10277: [C++] Support comparing scalars approximately#8438liyafan82 wants to merge 1 commit intoapache:masterfrom
liyafan82 wants to merge 1 commit intoapache:masterfrom
Conversation
cd08795 to
9631e9f
Compare
08080b2 to
b59722f
Compare
b59722f to
ee0a7e3
Compare
Member
|
Sorry for the delay @liyafan82 . I will take a look at this now. |
Member
|
I more or less rewrote this PR entirely as I identified other issues that were entangled with this one, and added a bunch of tests. |
Member
|
+1. Will merge now that this is green. |
Contributor
Author
|
@pitrou Thanks for your effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #7748 (comment), we need to compare scalars approximately in some scenarios.
Also: