ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type#7478
ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type#7478kszucs wants to merge 11 commits intoapache:masterfrom
Conversation
|
I pushed some changes to the R bindings to take advantage of this. I'll note that MinMax also doesn't support boolean and probably should. |
There was a problem hiding this comment.
BooleanArray has no raw_values() method.
There was a problem hiding this comment.
So these were returning the types' extreme values.
d1a85d1 to
fbdd84f
Compare
nealrichardson
left a comment
There was a problem hiding this comment.
From the R side, this LGTM
|
ping @wesm |
|
Looking |
wesm
left a comment
There was a problem hiding this comment.
The min/max implementation seems more complicated / less efficient than it needs to be, and I think the unit test setup could be simplified, but otherwise this looks OK
|
@ursabot build |
wesm
left a comment
There was a problem hiding this comment.
+1. We will have to resolve the sum([]) -> null/0 by introducing a "minimum valid values" option.
- minimum # valid values == 0 -> 0
- minimum # valid values == 1 -> null
Do we already have a JIRA to track this? EDIT -> it is mentioned in ARROW-9054 |
No description provided.