ARROW-7784: [C++] Improve compilation time of arrow/array/diff.cc and reduce code size#7311
Closed
wesm wants to merge 5 commits intoapache:masterfrom
Closed
ARROW-7784: [C++] Improve compilation time of arrow/array/diff.cc and reduce code size#7311wesm wants to merge 5 commits intoapache:masterfrom
wesm wants to merge 5 commits intoapache:masterfrom
Conversation
Member
Author
|
FTR it seems like the custom value formatters here could be merged with some code elsewhere in the codebase ( https://gist.github.com/wesm/9d4c5850d218ef722a77825f1da6f991 |
bkietz
approved these changes
Jun 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors diff.cc slightly to instantiate fewer templates.
On my machine with clang-8:
There are probably more improvements here both in compilation time and code size but cutting 10 seconds out of release builds is already a good improvement.