ARROW-7760: [Release] Fix verify-release-candidate.sh since pip3 seems to no longer be in miniconda, install miniconda unconditionally#6348
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
There was a problem hiding this comment.
If you are sure you're using Python 3, I would say python3 -m pip install ... is the surest way.
There was a problem hiding this comment.
This step is invoked from within a conda environment that is set up in the script. I guess recently (January 2020-related?) the pip3 alias disappeared
There was a problem hiding this comment.
The conda environment wouldn't have been installed in certain flag configuration:
TEST_DEFAULT=0 TEST_INTEGRATION_GO=1 dev/release/verify-release-candidate.sh source 0.16.0 2There was a problem hiding this comment.
Changed the script to always use miniconda.
|
+1 |
|
I'm just running this locally and then will merge |
|
There's still some problems, working on fixes |
… disabled. Fix selective disabling of integration test components in archery
|
There were multiple other problems:
|
|
+1 again, I've put this through the paces locally (had to modify the verification script to install |
…s to no longer be in miniconda, install miniconda unconditionally This change was necessary for me to get the script to finish to completion. Closes #6348 from wesm/pip3-to-pip and squashes the following commits: fcf3ae6 <Wes McKinney> conda environment must be activated for other steps to work if C++ is disabled. Fix selective disabling of integration test components in archery 26da759 <Krisztián Szűcs> always set up miniconda 490ceac <Wes McKinney> pip3 no longer in miniconda Lead-authored-by: Wes McKinney <wesm+git@apache.org> Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Wes McKinney <wesm+git@apache.org>
This change was necessary for me to get the script to finish to completion.