ARROW-7734: [C++] check status details for nullptr in equality#6332
Closed
lidavidm wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-7734: [C++] check status details for nullptr in equality#6332lidavidm wants to merge 1 commit intoapache:masterfrom
lidavidm wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Nice catch, I think this was my bug :( |
kszucs
pushed a commit
that referenced
this pull request
Feb 7, 2020
When checking statuses for equality, check to make sure that both have status detail objects before proceeding to compare those objects. Closes #6332 from lidavidm/arrow-7734 and squashes the following commits: 9084bce <David Li> ARROW-7734: check status details for nullptr in equality Authored-by: David Li <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking statuses for equality, check to make sure that both have status detail objects before proceeding to compare those objects.