ARROW-1562: [C++] Numeric kernel implementations for add#5021
ARROW-1562: [C++] Numeric kernel implementations for add#5021fexolm wants to merge 5 commits intoapache:masterfrom
Conversation
|
Multiple notes:
|
|
@fexolm it looks like @fsaintjacques gave some feedback on implementation do you need more guidance? |
|
@emkornfield no, I just can not find the time to finish this. I will return to this as soon as I get time. |
|
@fsaintjacques, @emkornfield |
7a6f7e1 to
a60b42f
Compare
|
Thanks @fexolm @fsaintjacques do you have time to review? |
|
Will review again. |
|
I created https://issues.apache.org/jira/browse/ARROW-7017 as a followup. |
It's just an initial AddKernel implementation (work in progress). I could not come up with a better implementation of type inference, so I want to hear your thoughts about implementation.