ARROW-5174: [Go] implement Stringer for DataTypes#4161
Closed
sbinet wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-5174: [Go] implement Stringer for DataTypes#4161sbinet wants to merge 1 commit intoapache:masterfrom
sbinet wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
needs #4160 |
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
===========================================
- Coverage 87.89% 60.53% -27.36%
===========================================
Files 758 67 -691
Lines 92163 4974 -87189
Branches 1251 0 -1251
===========================================
- Hits 81006 3011 -77995
+ Misses 11040 1847 -9193
+ Partials 117 116 -1
Continue to review full report at Codecov.
|
b7a0359 to
65173bd
Compare
Contributor
Author
Contributor
Author
|
(the Travis-CI error is unrelated (JDK-9 is acting up?)) |
Contributor
|
LGTM (except for arrow-cat and arrow-main that I did not fully review since I need read the whole thing first :)) |
Contributor
Author
|
thanks. feel free to comment on the PR(s) that I might have already collected and I'll retrofit those comments. |
wesm
pushed a commit
that referenced
this pull request
May 3, 2019
Needs #4161. Author: Sebastien Binet <binet@cern.ch> Closes #4228 from sbinet/issue-5233 and squashes the following commits: 323540c <Sebastien Binet> go/arrow/ipc: adapt to new flabuffers-v1.11 e82c908 <Sebastien Binet> go/arrow/ipc/feather: update format bca7dda <Sebastien Binet> go/arrow/internal/flatbuf: update format 93c7c5e <Sebastien Binet> ARROW-5233: Migrate to flatbuffers-v1.11.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.