ARROW-12869: [R] Bindings for utf8_reverse and ascii_reverse#10589
ARROW-12869: [R] Bindings for utf8_reverse and ascii_reverse#10589thisisnic wants to merge 6 commits intoapache:masterfrom
Conversation
|
Maybe map the function |
|
Looks good, thanks Nic! Could you please update the cheeky description to reflect that this PR is not quite so pointless now that it contains an actual function mapping? Then I'll merge. |
Good point...done! |
|
@ianmcook It's still not happy with that |
Dang, ok, this has been a learning experience for me! 🤦♂️ I'm of the opinion that it's bad to add new suggests unless there's a really good reason to do so. But maybe that's overzealous. Probably best to roll back to bcc7295 and let stringi be in the suggests. |
11065d5 to
bcc7295
Compare
Also fixes some test warnings. Still to-do: address the failing (now skipped) string reverse functions added in #10589. Closes #10706 from nealrichardson/arrow-12994 Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
This adds tests of the ascii_reverse kernel and a binding and tests for the stri_reverse function which calls the utf8_reverse kernel