Speedup interleave_views (4-7x faster)#7695
Merged
Dandandan merged 5 commits intoapache:mainfrom Jun 18, 2025
Merged
Conversation
cebc3dc to
f9c00ff
Compare
interleave_views (x4-6)
alamb
approved these changes
Jun 17, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
This makes a lot of sense to me -- thank you @Dandandan
Dandandan
commented
Jun 17, 2025
Contributor
|
Was the change to parquet-testing submodule intended? |
7478872 to
4b7d771
Compare
Contributor
Author
Thanks - fixed |
interleave_views (x4-6)interleave_views (4-7x faster)
Contributor
|
🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes: #7688
Rationale for this change
interleave_views is really slow - taking up ~25% of the samples in
SortPreservingMergeExecWe can make it faster.
Details
What changes are included in this PR?
Are there any user-facing changes?