Update PR template by commenting out instructions#278
Merged
Conversation
Some contributors don't remove the guidelines when creating PRs, so it might be more convenient if we hide them behind comments. The comments are still visible when editing, but are not displayed when the markdown is rendered
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 82.53% 82.53%
=======================================
Files 162 162
Lines 43796 43796
=======================================
Hits 36149 36149
Misses 7647 7647 Continue to review full report at Codecov.
|
alamb
added a commit
to apache/datafusion
that referenced
this pull request
May 10, 2021
Inspired by @nevi-me 's PR apache/arrow-rs#278 Some contributors don't remove the guidelines when creating PRs, so it might be more convenient if we hide them behind comments. The comments are still visible when editing, but are not displayed when the markdown is rendered
alamb
added a commit
to apache/datafusion
that referenced
this pull request
May 11, 2021
* Update PR template by commenting out instructions Inspired by @nevi-me 's PR apache/arrow-rs#278 Some contributors don't remove the guidelines when creating PRs, so it might be more convenient if we hide them behind comments. The comments are still visible when editing, but are not displayed when the markdown is rendered * Apply suggestions from code review Co-authored-by: Wakahisa <nevilledips@gmail.com> Co-authored-by: Wakahisa <nevilledips@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #277.
Rationale for this change
Some contributors don't remove the guidelines when creating PRs, so it might be more convenient if we hide them behind comments.
The comments are still visible when editing, but are not displayed when the markdown is rendered
What changes are included in this PR?
Comments out the text, but not the headings of this PR template.
Are there any user-facing changes?
No