feat: Add custom metadata support for IPC messages and RecordBatch#361
Open
rustyconover wants to merge 3 commits intoapache:mainfrom
Open
feat: Add custom metadata support for IPC messages and RecordBatch#361rustyconover wants to merge 3 commits intoapache:mainfrom
rustyconover wants to merge 3 commits intoapache:mainfrom
Conversation
Decode and expose custom metadata from IPC message headers, propagating it through the reader to RecordBatch instances. This allows accessing per-batch metadata stored in Arrow IPC streams and files.
Extend RecordBatchWriter to support writing custom metadata to IPC
messages, similar to PyArrow's write_batch(batch, custom_metadata=...).
Changes:
- Update Message.from() to accept optional metadata parameter
- Update Message.encode() to serialize custom metadata to FlatBuffers
- Add customMetadata parameter to RecordBatchWriter.write()
- Add mergeMetadata() helper that combines batch.metadata with the
parameter (parameter takes precedence for duplicate keys)
- Add comprehensive integration tests for write/read round-trip
Usage:
writer.write(batch, new Map([['key', 'value']]));
trxcllnt
requested changes
Jan 15, 2026
Contributor
trxcllnt
left a comment
There was a problem hiding this comment.
Looks good so far, just a few questions about the writer API.
| } | ||
| if (header instanceof RecordBatch) { | ||
| return new Message(bodyLength, MetadataVersion.V5, MessageHeader.RecordBatch, header); | ||
| return new Message(bodyLength, MetadataVersion.V5, MessageHeader.RecordBatch, header, metadata); |
Contributor
There was a problem hiding this comment.
Suggested change
| return new Message(bodyLength, MetadataVersion.V5, MessageHeader.RecordBatch, header, metadata); | |
| return new Message(bodyLength, MetadataVersion.V5, MessageHeader.RecordBatch, header, header.metadata); |
|
|
||
| /** @nocollapse */ | ||
| public static from(header: Schema | RecordBatch | DictionaryBatch, bodyLength = 0) { | ||
| public static from(header: Schema | RecordBatch | DictionaryBatch, bodyLength = 0, metadata?: Map<string, string>) { |
Contributor
There was a problem hiding this comment.
Since the second metadata argument is only relevant if we're serializing a RecordBatch message, can we just use its metadata field instead?
Suggested change
| public static from(header: Schema | RecordBatch | DictionaryBatch, bodyLength = 0, metadata?: Map<string, string>) { | |
| public static from(header: Schema | RecordBatch | DictionaryBatch, bodyLength = 0) { |
Contributor
There was a problem hiding this comment.
If the Message reads the metadata from the RecordBatch, this can all be simplified.
Comment on lines
+52
to
+56
| const batch = createTestBatch(); | ||
| const metadata = new Map([['batch_id', '123'], ['source', 'test']]); | ||
|
|
||
| const writer = new RecordBatchStreamWriter(); | ||
| writer.write(batch, metadata); |
Contributor
There was a problem hiding this comment.
Then we can do this:
Suggested change
| const batch = createTestBatch(); | |
| const metadata = new Map([['batch_id', '123'], ['source', 'test']]); | |
| const writer = new RecordBatchStreamWriter(); | |
| writer.write(batch, metadata); | |
| const batch = createTestBatch(); | |
| batch.metadata.set('batch_id', '123'); | |
| batch.metadata.set('source', 'test'); | |
| const writer = new RecordBatchStreamWriter(); | |
| writer.write(batch); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Decode and expose custom metadata from IPC message headers, propagating it through the reader to RecordBatch instances. This allows accessing per-batch metadata stored in Arrow IPC streams and files.
Extend RecordBatchWriter to support writing custom metadata to IPC messages, similar to PyArrow's write_batch(batch, custom_metadata=...).
Changes:
parameter (parameter takes precedence for duplicate keys)
Usage:
writer.write(batch, new Map([['key', 'value']]));