Skip to content

docs: fix broken links in FAQ#4053

Merged
spacewander merged 15 commits into
apache:masterfrom
KishaniKandasamy:KishaniKandasamy-patch-1
Apr 19, 2021
Merged

docs: fix broken links in FAQ#4053
spacewander merged 15 commits into
apache:masterfrom
KishaniKandasamy:KishaniKandasamy-patch-1

Conversation

@KishaniKandasamy

@KishaniKandasamy KishaniKandasamy commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

fix: #310
update FAQ by fixing broken links

@KishaniKandasamy KishaniKandasamy changed the title fix: broken link for benchmark data fix: broken links in FAQ Apr 14, 2021
Comment thread docs/en/latest/FAQ.md Outdated
Comment thread docs/es/latest/FAQ.md Outdated
Comment thread docs/zh/latest/FAQ.md Outdated
@spacewander spacewander changed the title fix: broken links in FAQ docs: fix broken links in FAQ Apr 15, 2021
Comment thread docs/en/latest/FAQ.md Outdated
## Why does the `make deps` command fail in source installation?

When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md) document for installation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like we need to add install-dependencies to latest/config.json?
CC @juzhiyuan

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked, yea, we should

@KishaniKandasamy KishaniKandasamy Apr 15, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve this so that I can merge it

@KishaniKandasamy KishaniKandasamy Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think it will work fine without adding install-dependencies to latest/config.json🤔 ( as same as how to build doc).
1
2

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier, the issue we had, is install-dependencies.md(install-dependencies.md) instead of install dependencies(install-dependencies.md)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't add them to config.json, we could render it, but without the left sidebar actually 😂

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mean the left sidebar of our website. The config.json is the index.

Comment thread docs/en/latest/FAQ.md
## Why does the `make deps` command fail in source installation?

When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](install-dependencies.md) document for installation.
When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install dependencies](install-dependencies.md) document for installation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think It will work

Comment thread docs/en/latest/FAQ.md Outdated
},
{
"type": "doc",
"id": "install-dependencies"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to do the same thing with docs/zh/latest/config.json

@spacewander spacewander merged commit 43b6e0d into apache:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

broken link in Apisix FAQ

4 participants