Skip to content

feat: support Plugins Hub#437

Merged
liuxiran merged 21 commits into
apache:masterfrom
KishaniKandasamy:master
Aug 16, 2021
Merged

feat: support Plugins Hub#437
liuxiran merged 21 commits into
apache:masterfrom
KishaniKandasamy:master

Conversation

@KishaniKandasamy

Copy link
Copy Markdown
Contributor

Fixes: #409

Changes:
I have added a plugin hub by using list of plugins available in the APISIX dashboard.

Screenshots of the change:

zoom_0.mp4

Please review when you are available

@netlify

netlify Bot commented Aug 5, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for apisix ready!

🔨 Explore the source changes: 89eddca

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix/deploys/610f5a9a7f45c00008f96e1a

😎 Browse the preview: https://deploy-preview-437--apisix.netlify.app

@KishaniKandasamy KishaniKandasamy changed the title feature: support Plugins Hub feat: support Plugins Hub Aug 5, 2021

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's very cool to see this page!

Comment thread website/static/data/plugin.json Outdated
Comment thread website/static/data/plugin.json
Comment thread website/src/pages/pluginhub.js Outdated
Comment thread website/docusaurus.config.js Outdated
@juzhiyuan juzhiyuan requested review from Yiyiyimu and liuxiran August 6, 2021 02:46
Comment thread website/src/pages/pluginhub.js Outdated
Comment thread website/src/pages/pluginhub.js Outdated
KishaniKandasamy and others added 6 commits August 6, 2021 10:17
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: Baoyuan <baoyuan.top@gmail.com>
Co-authored-by: Baoyuan <baoyuan.top@gmail.com>
Comment thread website/docusaurus.config.js Outdated
Comment thread website/src/pages/pluginhub.js Outdated
@1502shivam-singh

Copy link
Copy Markdown
Member

Please review when you are available

Hey @KishaniKandasamy , really nice work :)
Something I would suggest, it's optional but would appreciate if it would be possible, you could add a fixed sidebar to this section (as in the wireframe I provided) to easily traverse between sections, you know to eliminate long scrolls. The labels in the sidebar can reference sections using anchor links so as to provide better usability. This is in view that this list will get longer eventually in the future.

KishaniKandasamy and others added 2 commits August 6, 2021 22:59
Co-authored-by: Shivam Singh <57267960+1502shivam-singh@users.noreply.github.com>
Co-authored-by: Shivam Singh <57267960+1502shivam-singh@users.noreply.github.com>
@KishaniKandasamy

KishaniKandasamy commented Aug 6, 2021

Copy link
Copy Markdown
Contributor Author

Please review when you are available

Hey @KishaniKandasamy , really nice work :)
Something I would suggest, it's optional but would appreciate if it would be possible, you could add a fixed sidebar to this section (as in the wireframe I provided) to easily traverse between sections, you know to eliminate long scrolls. The labels in the sidebar can reference sections using anchor links so as to provide better usability. This is in view that this list will get longer eventually in the future.

@1502shivam-singh many thanks for your feedback ;) Yes I agree. I will commit those changes

@KishaniKandasamy

KishaniKandasamy commented Aug 6, 2021

Copy link
Copy Markdown
Contributor Author

Hi everyone , I have added a sidebar .Please let me know your suggestions !

Screenshot (381)

@1502shivam-singh

Copy link
Copy Markdown
Member

Hi everyone , I have added a sidebar .Please let me know your suggestions !

Screenshot (381)

Looks good. I guess you can keep the labels in sidebar as normal, non-italicised ones. Rest looks good to me.

@KishaniKandasamy

Copy link
Copy Markdown
Contributor Author

Hi everyone , I have added a sidebar .Please let me know your suggestions !
Screenshot (381)

Looks good. I guess you can keep the labels in sidebar as normal, non-italicised ones. Rest looks good to me.

Done !

@1502shivam-singh

Copy link
Copy Markdown
Member

I guess we are clear then, rest LGTM.

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the map key :)

Comment thread website/src/pages/pluginhub.js Outdated
KishaniKandasamy and others added 2 commits August 8, 2021 09:44
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
@KishaniKandasamy

KishaniKandasamy commented Aug 8, 2021

Copy link
Copy Markdown
Contributor Author

Please take a look at the map key :)
@juzhiyuan fixed ;)

Comment thread website/src/pages/pluginhub.js Outdated
@KishaniKandasamy

KishaniKandasamy commented Aug 8, 2021

Copy link
Copy Markdown
Contributor Author

Fixes: #409

Changes:
I have added a plugin hub by using list of plugins available in the APISIX dashboard.

Screenshots of the change:

zoom_0.mp4
Please review when you are available

@Yiyiyimu @liuxiran

@liuxiran liuxiran merged commit af6e33c into apache:master Aug 16, 2021
@liuxiran

Copy link
Copy Markdown
Contributor

merged, thanks for your contribution ~

1502shivam-singh added a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
Co-authored-by: Baoyuan <baoyuan.top@gmail.com>
Co-authored-by: Shivam Singh <57267960+1502shivam-singh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: support Plugins Hub

5 participants