Skip to content

feat: added company who uses Apache APISIX logo#410

Merged
juzhiyuan merged 6 commits into
apache:masterfrom
guoqqqi:update-showcases
Jul 30, 2021
Merged

feat: added company who uses Apache APISIX logo#410
juzhiyuan merged 6 commits into
apache:masterfrom
guoqqqi:update-showcases

Conversation

@guoqqqi

@guoqqqi guoqqqi commented Jul 13, 2021

Copy link
Copy Markdown
Member

Fixes: #[Add issue number here]

Changes:

added company who uses Apache APISIX logo

Screenshots of the change:

@netlify

netlify Bot commented Jul 13, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for apisix ready!

🔨 Explore the source changes: 35d9286

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix/deploys/6100cc853e646500070035bd

😎 Browse the preview: https://deploy-preview-410--apisix.netlify.app

@guoqqqi

guoqqqi commented Jul 13, 2021

Copy link
Copy Markdown
Member Author

image

@iamayushdas

Copy link
Copy Markdown
Contributor

Nice

@guoqqqi

guoqqqi commented Jul 13, 2021

Copy link
Copy Markdown
Member Author
  • 思必驰信息科技股份有限公司
  • 浙江大东鞋业有限公司
  • 上海合合信息科技股份有限公司

The above logo is white and needs to be replaced

The logo that can be added has been added, the rest of the CC @iamayushdas

@guoqqqi
guoqqqi marked this pull request as ready for review July 13, 2021 04:14
@iamayushdas

Copy link
Copy Markdown
Contributor
  • 思必驰信息科技股份有限公司

  • 浙江大东鞋业有限公司

  • 上海合合信息科技股份有限公司

The above logo is white and needs to be replaced

The logo that can be added has been added, the rest of the CC @iamayushdas

Okay

@iamayushdas iamayushdas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moonming

Copy link
Copy Markdown
Member

will also update apisix's readme?

@iamayushdas

Copy link
Copy Markdown
Contributor

will also update apisix's readme?

I will be adding to readme company wall after putting the missing icons.

@Yiyiyimu

Copy link
Copy Markdown
Member

@guoqqqi suggest to remove zihao and zhi20 due to #376 (comment)

  1. Remove zhi20 due to suspected pyramid scheme
  2. Remove zihaowangluo since it's an outsourcing company

Also we need to turn the white background to transparency (add alpha channel) to make it compatible with night mode

@Yiyiyimu Yiyiyimu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add alpha channel to make background transparency to be compatible with dark mode

@Yiyiyimu

Copy link
Copy Markdown
Member

cc @guoqqqi do you have some progress on this

@guoqqqi
guoqqqi requested a review from Yiyiyimu July 27, 2021 09:12
@Yiyiyimu

Copy link
Copy Markdown
Member

suggest to remove zihao and zhi20 due to #376 (comment)

  1. Remove zhi20 due to suspected pyramid scheme
  2. Remove zihaowangluo since it's an outsourcing company

Hi @guoqqqi do you mind fix this problem

@guoqqqi

guoqqqi commented Jul 28, 2021

Copy link
Copy Markdown
Member Author

Hi @guoqqqi do you mind fix this problem

@Yiyiyimu Hi, I have removed them in this PR

@Yiyiyimu

Copy link
Copy Markdown
Member

@guoqqqi it seems icon of zhi20 haven't been removed yet

@guoqqqi

guoqqqi commented Jul 29, 2021

Copy link
Copy Markdown
Member Author

image
@Yiyiyimu It has been removed

@Yiyiyimu
Yiyiyimu requested a review from juzhiyuan July 29, 2021 14:59
@juzhiyuan
juzhiyuan merged commit c1211eb into apache:master Jul 30, 2021
1502shivam-singh pushed a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants