Skip to content

fix: added navigation path name for Go Runner#403

Merged
Yiyiyimu merged 14 commits into
apache:masterfrom
iamayushdas:GoRunner
Jul 12, 2021
Merged

fix: added navigation path name for Go Runner#403
Yiyiyimu merged 14 commits into
apache:masterfrom
iamayushdas:GoRunner

Conversation

@iamayushdas

Copy link
Copy Markdown
Contributor

Fixes: #[Add issue number here]

Changes:

fixed navigation path name for Go Runner

Screenshots of the change:

Untitled

@netlify

netlify Bot commented Jul 7, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for apisix ready!

🔨 Explore the source changes: 3373e39

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix/deploys/60ec28a2e8a66b00070c5b07

😎 Browse the preview: https://deploy-preview-403--apisix.netlify.app

@iamayushdas

Copy link
Copy Markdown
Contributor Author

cc @Yiyiyimu @juzhiyuan

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be plugin runner?

@iamayushdas

Copy link
Copy Markdown
Contributor Author

Yes but the it was already labelled as Go Runner so i keep it like that only,
Should i change both?

@juzhiyuan

Copy link
Copy Markdown
Member

just wait for other reviewers

@iamayushdas

Copy link
Copy Markdown
Contributor Author

just wait for other reviewers

fixed after #405

@iamayushdas iamayushdas requested a review from juzhiyuan July 8, 2021 14:11
@Yiyiyimu

Yiyiyimu commented Jul 9, 2021

Copy link
Copy Markdown
Member

@iamayushdas do you mind merge master to see the change in #405

@iamayushdas

Copy link
Copy Markdown
Contributor Author

@Yiyiyimu have a look

@Yiyiyimu Yiyiyimu merged commit 56f4d90 into apache:master Jul 12, 2021
1502shivam-singh pushed a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants