Skip to content

docs: fixed kubernetes service api broken link#328

Merged
Yiyiyimu merged 3 commits into
apache:masterfrom
xdshivani:326
May 27, 2021
Merged

docs: fixed kubernetes service api broken link#328
Yiyiyimu merged 3 commits into
apache:masterfrom
xdshivani:326

Conversation

@xdshivani

Copy link
Copy Markdown
Contributor

Fixes: #326

Changes:
fixed kubernetes service api broken link

Thankyou @iamayushdas for making me understand architecture of apisix-website.
Here is my first PR
Have a look to this

@netlify

netlify Bot commented May 4, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for apisix ready!

🔨 Explore the source changes: 267f0a7

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134

😎 Browse the preview: https://deploy-preview-328--apisix.netlify.app

@iamayushdas iamayushdas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tokers @Yiyiyimu have a review to this

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, do we have other URLs using https://kubernetes-sigs.github.io/service-apis/?

@Yiyiyimu Yiyiyimu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a lot of broken links found in #326, we'd better fix them all together in this PR

@xdshivani

Copy link
Copy Markdown
Contributor Author

There are quite a lot of broken links found in #326, we'd better fix them all together in this PR

I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again.

@iamayushdas

Copy link
Copy Markdown
Contributor

There are quite a lot of broken links found in #326, we'd better fix them all together in this PR

I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again.

Oh yes, zh folder doesn't exist now in docs. You can look for other links, if all links are working fine just ping me here.
Thank you for contribution

@Yiyiyimu

Yiyiyimu commented May 6, 2021

Copy link
Copy Markdown
Member

I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again.

The reason those links are broken is due to, apisix-ingress-controller does not contain Chinese doc, but on Chinese website, the edit link is pointing to zh link. So the logic of multi-language doc edit links need to fix. But we could leave it to another PR.

@iamayushdas

Copy link
Copy Markdown
Contributor

I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again.

The reason those links are broken is due to, apisix-ingress-controller does not contain Chinese doc, but on Chinese website, the edit link is pointing to zh link. So the logic of multi-language doc edit links need to fix. But we could leave it to another PR.

yes ofcourse, will look into it in another PR
Thanks for review

@Yiyiyimu

Yiyiyimu commented May 6, 2021

Copy link
Copy Markdown
Member

What about other links, like etcd/travelsky/aliyun

@iamayushdas

Copy link
Copy Markdown
Contributor

@xdshivani kindly have a look on other broken links residing there too like etcd/travelsky/aliyun

@LiteSun

LiteSun commented May 26, 2021

Copy link
Copy Markdown
Member

ping~

@Yiyiyimu

Copy link
Copy Markdown
Member

@LiteSun @xdshivani some other links need to be fixed

@xdshivani

Copy link
Copy Markdown
Contributor Author
  1. I am new to open source and I don't know why I am receiving these errors.
  2. I tried to find the broken links in local repo but, could not find it.
  3. The only faulty link I got was of kubernetes link and I fixed it in this PR @Yiyiyimu @iamayushdas

@iamayushdas

Copy link
Copy Markdown
Contributor

@xdshivani
see here for some reference
sinog2c.com

use these links instead:
http://www.sinog2c.com/
https://www.travelsky.com.cn/
https://partners-intl.aliyun.com/help/doc-detail/142666.htm for [Log server]
https://partners-intl.aliyun.com/help/doc-detail/25485.htm for [serve list]
https://www.alibabacloud.com/help/doc-detail/182218.htm [access services through SLB]

hope it helps

@Yiyiyimu

Copy link
Copy Markdown
Member

The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help

@iamayushdas

iamayushdas commented May 26, 2021

Copy link
Copy Markdown
Contributor

The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help

It would be a pleasure to help

@iamayushdas

iamayushdas commented May 27, 2021

Copy link
Copy Markdown
Contributor

The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help

It is already fixed now, thats why you aren't able to find the link

@Yiyiyimu Yiyiyimu merged commit ad81f9f into apache:master May 27, 2021
1502shivam-singh pushed a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: many broken links our residing in website

7 participants