Skip to content

chore: support dark mode and switch#289

Merged
juzhiyuan merged 1 commit into
apache:masterfrom
Yiyiyimu:feat/darkmode
Apr 9, 2021
Merged

chore: support dark mode and switch#289
juzhiyuan merged 1 commit into
apache:masterfrom
Yiyiyimu:feat/darkmode

Conversation

@Yiyiyimu

@Yiyiyimu Yiyiyimu commented Apr 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: yiyiyimu wosoyoung@gmail.com

Screenshots of the change:

image

@Yiyiyimu
chore: support dark mode and switch
e4fad74 
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@Yiyiyimu

Yiyiyimu commented Apr 8, 2021

Copy link
Copy Markdown
Member Author

An awkward thing is when text is not in black (for example some dark grey), dark mode seems could not get its opponent color...

image

One possible solution to deal with this situation is like the tagline of https://docusaurus.io/, to make it stale and not get affected by the dark mode.

Light mode
image

Dark mode
image

I tried to find the method to make it stale but failed 😿 crying again for not familiar with frontend

@jbampton

jbampton commented Apr 8, 2021

Copy link
Copy Markdown
Member

I think for sure it's like JS/CSS/HTML but I suck at front end too.
You may have seen some of my sites it's all weird purple disco.
But for sure dark mode is important so we need this

juzhiyuan
juzhiyuan approved these changes Apr 9, 2021
View reviewed changes

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it's wired due to some color issues, we still need this.

@juzhiyuan juzhiyuan requested a review from bzp2010 April 9, 2021 00:12
@juzhiyuan juzhiyuan merged commit e59f8c5 into apache:master Apr 9, 2021
@Yiyiyimu

Yiyiyimu commented Apr 9, 2021

Copy link
Copy Markdown
Member Author

Though it's wired due to some color issues, we still need this.

I'll create a new issue for this

1502shivam-singh added a commit to 1502shivam-singh/apisix-website that referenced this pull request May 20, 2021
@1502shivam-singh
style change to hero and remove unused repeated h3
f5491e4 
docs: added dashboard (apache#221)

fix: pull request in place of apache#214 (apache#222)

fix: changes to title style on landing page and doc addition

Co-authored-by: Amit Wani <amit.wani@cognizant.com>

docs: added dashboard (apache#225)

docs: added blog `Get Front-End Test Coverage with Cypress`  (apache#227)

fix: Wrong doc url (apache#231)

fix: some url path can't replace by absolute url path (apache#237)

Co-authored-by: coolsoul <coolsoul0551@qq.com>
Co-authored-by: 琚致远 <juzhiyuan@apache.org>

feat: support edit this page & update styles (apache#235)

chore: fix release guide since doc layout changed (apache#238)

docs: added Integrate with Projects documentations (apache#234)

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

added latest styles

feat: algolia docSearch apache#226 (apache#241)

docs: use getting-started for ingress-controller (apache#242)

feat: upgrade APISIX version (apache#244)

fix: add <!--truncate--> to the blog markdown files apache#240 (apache#247)

fix: rectify the index doc page for apisix ingress controller (apache#249)

fix: fix the version number in mobile size overflow (apache#245)

fix: apache#220 (apache#239)

docs: added event about releasing APISIX 2.4 (apache#248)

docs: fixed broken powered-by.md link (apache#251)

docs: update navbar for apisix (apache#252)

fix: improved the description for users to join slack (apache#253)

chore: Add new committer jinchen in committer list (apache#254)

docs: add docs for ingress 0.4.0 (apache#258)

* docs: add docs for ingress 0.4.0

* docs: modify ingress downloads

* fix: lint

fix: update sync-docs.js (apache#257)

feat: improve documents synchronize (apache#262)

feat: sync user wall data (apache#260)

feat: support toggle sidebar (apache#269)

chore: move Chao Zhang from Committers to PMCs (apache#267)

feat: apache#216 add helm-chart project (apache#273)

fix: add a bundle of good first issues links to homepage  (apache#274)

feat: support apisix-docker (apache#275)

feat: broken link checker script (apache#263)

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

feat: apache#266 speed up static file (apache#270)

feat: upgrade APISIX Dashboard version (apache#276)

feat: support to load other projects (apache#277)

chore(deps): bump peaceiris/actions-gh-pages from v3 to v3.8.0 (apache#271)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: upgrade APISIX 2.5 (apache#279)

chore: remove downloads for docker & helm chart (apache#284)

feat: APISIX 2.5 event (apache#283)

docs: added a new blog "Traffic Split in Apache APISIX Ingress Controller" (apache#286)

chore: support dark mode and switch (apache#289)

chore: support hide navbar on scroll down (apache#290)

fix: page not found for apisix docker and apisix helm chart (apache#282)

Co-authored-by: Ayush das <ayush24das@gmail.com>

fix: add truncate and source to newly added blog (apache#296)

* update traffic-split-in-ingress-controller.md

* Update website/blog/2021-03-27-traffic-split-in-apache-apisix-ingress-controller.md

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>

fix: disable version switch button in sidebar, as website doesn't support it (apache#299)

fix: padding to arrow inside collapse sidebar button, and fit button to sidebar width (apache#300)

fix: darkMode enhanced (apache#297)

chore: release ingress controller 0.5.0 (apache#305)

* chore: release ingress controller 0.5.0

* feat: add event

fix: broken link in  release guide (apache#306)

docs: update the architecture diagram (apache#309)

chore: add alpha channel to showcase image for dark mode (apache#303)

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

chore: Fix GitHub-icon sizes in team page  (apache#313)

docs: update logo wall (apache#315)

chore: upgrade APISIX Dashboard version to 2.6 (apache#317)

docs: update logo wall (apache#316)

docs: update download link (apache#320)

docs: update integration page (apache#327)

chore: Test Docusaurus webpack 5 support (apache#318)

feat: added last updated time (apache#331)

docs: fix broken links in Run Ingress on Amazon EKS blog (apache#333)

update docusaurus.config.json (apache#334)

feat: darkmode added to download-dropdown (apache#336)

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

chore(deps): bump actions/setup-python from 2 to 2.2.2 (apache#339)

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump actions/checkout from 2 to 2.3.4 (apache#337)

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump actions/setup-node from 2 to 2.1.5 (apache#338)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

release ingress 0.6.0 (apache#343)

docs: include  Helm charts and Docker to documents page (apache#342)

feat: added meta image (apache#345)

squashing: merge history commits on docs and landing page
1502shivam-singh added a commit to 1502shivam-singh/apisix-website that referenced this pull request May 20, 2021
@1502shivam-singh
style change to hero and remove unused repeated h3
5a2355b 
docs: added dashboard (apache#221)

fix: pull request in place of apache#214 (apache#222)

fix: changes to title style on landing page and doc addition

Co-authored-by: Amit Wani <amit.wani@cognizant.com>

docs: added dashboard (apache#225)

docs: added blog `Get Front-End Test Coverage with Cypress`  (apache#227)

fix: Wrong doc url (apache#231)

fix: some url path can't replace by absolute url path (apache#237)

Co-authored-by: coolsoul <coolsoul0551@qq.com>
Co-authored-by: 琚致远 <juzhiyuan@apache.org>

feat: support edit this page & update styles (apache#235)

chore: fix release guide since doc layout changed (apache#238)

docs: added Integrate with Projects documentations (apache#234)

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

added latest styles

feat: algolia docSearch apache#226 (apache#241)

docs: use getting-started for ingress-controller (apache#242)

feat: upgrade APISIX version (apache#244)

fix: add <!--truncate--> to the blog markdown files apache#240 (apache#247)

fix: rectify the index doc page for apisix ingress controller (apache#249)

fix: fix the version number in mobile size overflow (apache#245)

fix: apache#220 (apache#239)

docs: added event about releasing APISIX 2.4 (apache#248)

docs: fixed broken powered-by.md link (apache#251)

docs: update navbar for apisix (apache#252)

fix: improved the description for users to join slack (apache#253)

chore: Add new committer jinchen in committer list (apache#254)

docs: add docs for ingress 0.4.0 (apache#258)

* docs: add docs for ingress 0.4.0

* docs: modify ingress downloads

* fix: lint

fix: update sync-docs.js (apache#257)

feat: improve documents synchronize (apache#262)

feat: sync user wall data (apache#260)

feat: support toggle sidebar (apache#269)

chore: move Chao Zhang from Committers to PMCs (apache#267)

feat: apache#216 add helm-chart project (apache#273)

fix: add a bundle of good first issues links to homepage  (apache#274)

feat: support apisix-docker (apache#275)

feat: broken link checker script (apache#263)

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

feat: apache#266 speed up static file (apache#270)

feat: upgrade APISIX Dashboard version (apache#276)

feat: support to load other projects (apache#277)

chore(deps): bump peaceiris/actions-gh-pages from v3 to v3.8.0 (apache#271)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: upgrade APISIX 2.5 (apache#279)

chore: remove downloads for docker & helm chart (apache#284)

feat: APISIX 2.5 event (apache#283)

docs: added a new blog "Traffic Split in Apache APISIX Ingress Controller" (apache#286)

chore: support dark mode and switch (apache#289)

chore: support hide navbar on scroll down (apache#290)

fix: page not found for apisix docker and apisix helm chart (apache#282)

Co-authored-by: Ayush das <ayush24das@gmail.com>

fix: add truncate and source to newly added blog (apache#296)

* update traffic-split-in-ingress-controller.md

* Update website/blog/2021-03-27-traffic-split-in-apache-apisix-ingress-controller.md

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>

fix: disable version switch button in sidebar, as website doesn't support it (apache#299)

fix: padding to arrow inside collapse sidebar button, and fit button to sidebar width (apache#300)

fix: darkMode enhanced (apache#297)

chore: release ingress controller 0.5.0 (apache#305)

* chore: release ingress controller 0.5.0

* feat: add event

fix: broken link in  release guide (apache#306)

docs: update the architecture diagram (apache#309)

chore: add alpha channel to showcase image for dark mode (apache#303)

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

chore: Fix GitHub-icon sizes in team page  (apache#313)

docs: update logo wall (apache#315)

chore: upgrade APISIX Dashboard version to 2.6 (apache#317)

docs: update logo wall (apache#316)

docs: update download link (apache#320)

docs: update integration page (apache#327)

chore: Test Docusaurus webpack 5 support (apache#318)

feat: added last updated time (apache#331)

docs: fix broken links in Run Ingress on Amazon EKS blog (apache#333)

update docusaurus.config.json (apache#334)

feat: darkmode added to download-dropdown (apache#336)

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

chore(deps): bump actions/setup-python from 2 to 2.2.2 (apache#339)

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump actions/checkout from 2 to 2.3.4 (apache#337)

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump actions/setup-node from 2 to 2.1.5 (apache#338)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

release ingress 0.6.0 (apache#343)

docs: include  Helm charts and Docker to documents page (apache#342)

feat: added meta image (apache#345)

squashing: merge history commits on docs and landing page

set max-width attribute to docMainContainer class

set max-width attribute to docMainContainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes
@tokers tokers tokers approved these changes
@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yiyiyimu @jbampton @juzhiyuan @tokers