Make Gantt tooltip the same as Tree and Graph view - #8220

Merged

ashb merged 2 commits into

apache:masterfrom

ashb:gantt-tooltip-same-as-tree

Apr 9, 2020

ashb commented Apr 8, 2020

Member

To make this work I needed to change the fields exposed via the json
representation to those expected via the tiTooltip function.

Closes #8210.

Before

After:

Make sure to mark the boxes below before creating PR: [x]

Description above provides context of the change
Unit tests coverage for changes (not needed for documentation changes)
Commits follow "How to write a good git commit message"
Relevant documentation is updated including usage instructions.
I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.


          Make Gantt tooltip the same as Tree and Graph view

25f8e2e

To make this work I needed to change the fields exposed via the json
representation to those expected via the `tiTooltip` function.

Closes apache#8210

boring-cyborg Bot added the area:webserver label

ashb force-pushed the gantt-tooltip-same-as-tree branch from 49d8c92 to 25f8e2e Compare

April 8, 2020 17:55

ashb commented Apr 8, 2020

Member Author

Though it loos like there is a bug in the Duration display for the tiTooltip function I reused.

ashb requested review from kaxil and mik-laj

April 9, 2020 10:13

kaxil reviewed

View reviewed changes

airflow/www/static/js/gantt-chart-d3v2.js Outdated

    
                var keyFunction = function(d) {

                  return d.startDate + d.taskName + d.endDate;

                  return d.start_ate + d.task_id + d.end_date;

kaxil Apr 9, 2020

Member

Typo

ashb Apr 9, 2020

Member Author

Whops :)

kaxil reviewed

View reviewed changes

airflow/www/static/js/gantt-chart-d3v2.js Outdated

kaxil approved these changes

View reviewed changes

kaxil left a comment

Member

1 Typo that needs fixing or else LGTM


          Update airflow/www/static/js/gantt-chart-d3v2.js

624750a

Co-Authored-By: Kaxil Naik <kaxilnaik@gmail.com>

ashb merged commit 08c9b0a into apache:master

ashb deleted the gantt-tooltip-same-as-tree branch

April 9, 2020 20:20

ashb added this to the Airflow 1.10.11 milestone

kaxil mentioned this pull request

Remove unused code from Gannt View #8302

Merged

5 tasks

kaxil added a commit that referenced this pull request


          Remove unused code from Gannt View (#8302)

54d3c9a

After #8220 we do not need task_types and extra_links variables

kaxil mentioned this pull request

Fix Extra Links in Gannt View #8308

Merged

5 tasks

kaxil pushed a commit that referenced this pull request


          Make Gantt tooltip the same as Tree and Graph view (#8220)

94757dd

To make this work I needed to change the fields exposed via the json
representation to those expected via the `tiTooltip` function.

Closes #8210

kaxil added a commit that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

1fbe8d8

Extra link didn't appear after changes in  #8220 for Gantt View

kaxil added a commit that referenced this pull request


          Remove unused code from Gannt View (#8302)

bc93bae

After #8220 we do not need task_types and extra_links variables

kaxil added a commit that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

504c711

Extra link didn't appear after changes in  #8220 for Gantt View

kaxil mentioned this pull request

Gantt chart for running dag doesn't show up in Airflow 1.10.11 #9813

Closed

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

8d47396

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: bc93bae16989ce86caee56058a84af3c6dd4a739

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

90fb9dc

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 504c711a6a7a0631745d3a36d628739e7540c7aa

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

4ee24db

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: bc93bae16989ce86caee56058a84af3c6dd4a739

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

1af91b3

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 504c711a6a7a0631745d3a36d628739e7540c7aa

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

c12dc3d

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 504c711a6a7a0631745d3a36d628739e7540c7aa

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

dd4d8a4

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: bc93bae16989ce86caee56058a84af3c6dd4a739

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 504c711a6a7a0631745d3a36d628739e7540c7aa

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

8cf19aa

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

293904a

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

a2a1317

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

59d7d17

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

a066942

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

666a266

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

ccaba06

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

4ebd074

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

1839aad

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

ede044f

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

170928a

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

d3a6e14

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

d15c9cb

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

96c24bc

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

f630882

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

4f4f396

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

478c395

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

12d853b

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

abace90

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

22c47ea

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

ebad4d1

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

af8447e

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

428a250

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

59c17e9

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Remove unused code from Gannt View (#8302)

1ce558b

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request


          Fix Extra Links in Gannt View (#8308)

9bda765

Extra link didn't appear after changes in  apache/airflow#8220 for Gantt View

GitOrigin-RevId: 1fbe8d8bee164de81e8ac9332e1d49f0de03b3e0

kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request


          Remove unused code from Gannt View (#8302)

d71e6c0

After apache/airflow#8220 we do not need task_types and extra_links variables

GitOrigin-RevId: 54d3c9a55c974ecb1ea2b4524294ffbc42905ac2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels