Skip to content

Fix mypy arg-type error in Redshift Data get_primary_keys - #70677

Merged
Lee-W merged 1 commit into
apache:mainfrom
astronomer:fix-mypy-error
Jul 29, 2026
Merged

Fix mypy arg-type error in Redshift Data get_primary_keys#70677
Lee-W merged 1 commit into
apache:mainfrom
astronomer:fix-mypy-error

Conversation

@Lee-W

@Lee-W Lee-W commented Jul 29, 2026

Copy link
Copy Markdown
Member

Why

In #70501,

    providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_data.py:274: error: Argument 1 to "get_statement_result" of "RedshiftDataAPIServiceClient" has incompatible type "**dict[str, str]";
    expected "int"  [arg-type]
                    response = self.conn.get_statement_result(**kwargs)
                                                                ^~~~~~

kwargs was infereed as dict[str, int]

What

Annotate it as dict[str, Any]


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Lee-W
Lee-W merged commit f388d42 into apache:main Jul 29, 2026
83 checks passed
@Lee-W
Lee-W deleted the fix-mypy-error branch July 29, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants