Fix Azure Data Factory hook broken with azure-mgmt-datafactory 10#69800
Conversation
aafc189 to
16a5694
Compare
16a5694 to
4a38e38
Compare
|
@eladkal I like this, but I'm not sure we've done something like this before. Increasing the minimum supported version from 2 to 10 seems a bit aggressive, so I suggested keeping it backward compatible. |
eladkal
left a comment
There was a problem hiding this comment.
Temporary block till I take a closer look
|
OK, I reviewed the case and I think it's OK to support The @FrankYang0529 can you please adjust the code for that? |
|
Thanks for the review. I will update it today. |
Signed-off-by: PoAn Yang <payang@apache.org>
4a38e38 to
ceafa4b
Compare
Signed-off-by: PoAn Yang <payang@apache.org>
ceafa4b to
0bdf13c
Compare
|
Updated it. Thank you. |
Merging then, thanks. |
…ache#69800) * Fix Azure Data Factory hook broken by azure-mgmt-datafactory 10 Signed-off-by: PoAn Yang <payang@apache.org> * Fix Azure Data Factory hook broken by azure-mgmt-datafactory 10 Signed-off-by: PoAn Yang <payang@apache.org> --------- Signed-off-by: PoAn Yang <payang@apache.org>
Why
azure-mgmt-datafactory9.3.0 → 10.0.0, which replaced theif_match/if_none_matchparameters withetag+match_conditionpair.How
azure.mgmt.datafactoryversion to determine kwargs:_ADF_SDK_V10_PLUSis computed from the installed major and the hook's publicif_match/if_none_matchparameters are translated accordingly.etag+match_condition.if_match/if_none_matchkwargs.Verification
uv run --project providers/microsoft/azure --with "azure-mgmt-datafactory==9.3.0" pytest providers/microsoft/azure/tests/unit/microsoft/azure/hooks/test_data_factory.py -quv run --project providers/microsoft/azure --with "azure-mgmt-datafactory==10.0.0" pytest providers/microsoft/azure/tests/unit/microsoft/azure/hooks/test_data_factory.py -qWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.