Fix Kafka consumer not being closed on error in ConsumeFromTopicOperator#69641
Open
TimurRakhmatullin86 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Timur Rakhmatullin <174210871+TimurRakhmatullin86@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsumeFromTopicOperator.executeonly calledconsumer.close()on the happy path. Ifapply_function/apply_function_batchraised, orconsumer.consume()/consumer.commit()failed, the operator leaked the consumer: the group member stays registered on the broker untilsession.timeout.msexpires (delaying partition rebalance for the rest of the consumer group), and the underlying librdkafka handle keeps its sockets and background threads alive in the worker until GC.This wraps the processing loop in
try/finallyso the consumer is always closed:try, so nothing is committed for a failed batch;close()infinallyis guarded with alog.warning, mirroring theAwaitMessageTriggerconsumer cleanup from Add cleanup to Kafka AwaitMessageTrigger for consumer management #64612 —close()performs a final synchronous offset commit whenenable.auto.commitis on (the librdkafka default), so it can itself raise and would otherwise replace the original processing error as the task failure reason.Tests:
test_execute_closes_consumer_when_apply_function_raises(fails without the fix) andtest_execute_does_not_mask_error_when_close_raises.