Rerun flaky SSHRemoteJobOperator kill test on process-group races#69384
Merged
Conversation
test_kill_terminates_whole_job_tree intermittently fails its pre-kill check on CI: the wrapper records $! expecting it to equal the job PGID, but setsid only skips forking when the launching shell is not a process-group leader. On some runners it forks, so $! is the short-lived setsid parent and the job's real group is empty by the time pgrep -g runs. Rerun on a fresh draw so the environment-dependent race does not fail unrelated PRs.
potiuk
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPosixKillBehaviour::test_kill_terminates_whole_job_tree(added in #68644) intermittently fails its pre-kill assertion on CI:The wrapper records
$!expecting it to equal the job PGID, butsetsidonly skips forking when the launching shell is not a process-group leader. On some runners it forks, so$!is the short-livedsetsidparent and the job's real process group is already empty by the timepgrep -gruns — failing the check before the kill is even exercised. Passes locally (15/15, and under xdist), fails only on certain CI runners, so it's environment-dependent and lands on unrelated PRs.Marks the test with
@pytest.mark.flaky(reruns=5)(the convention already used elsewhere in this provider) so a fresh re-launch clears the race.Note: if
setsidforks in a real SSH session too,$!would be the wrong PID there andon_killcould orphan the job — a possible latent issue in the wrapper itself, left for a separate change.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines