Parallelize per-dag auth checks in KeycloakAuthManager#69107
Merged
Conversation
Andrushika
marked this pull request as ready for review
June 28, 2026 15:40
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me. I have left 2 comments. Also, I believe you should expand test coverage (either by adding new unit tests or modifying exist ones) to include the new concurrency logic. In particular, it would be good to verify that ThreadPoolExecutor is created with the expected max_workers value (covering both len(dag_ids) and the configured pool size), while ensuring the existing authorization behavior is preserved in both the single- and multi-worker cases.
vincbeck
approved these changes
Jun 29, 2026
Contributor
Author
|
Thanks for all the review! CI passed and all conversations are resolved. This should be ready for maintainer merge when convenient. |
eladkal
approved these changes
Jun 30, 2026
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
* Parallelize per-dag auth checks in KeycloakAuthManager * Fix team_name args not found * Add comment of thread pool size decision * Add test for checking thread pool size
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/dagsscreen is very slow to load with multiple teams #69041As the issue reported, users who use Keycloak as an auth backend are facing over 10 seconds of UI loading speed.
I took a look and discovered that
KeycloakAuthManager.filter_authorized_dag_ids()wraps the result with cache/single-flight, but on cache miss it falls back to the base auth manager implementation. The base implementation checks each Dag ID individually, so Keycloak sends one authorization HTTP request per Dag ID during that filter call.To address this problem, I use
ThreadPoolExecutorto run the per-dag checks concurrently.I tried to simulate and wrote a script for a local benchmark. Here's the result:
(50ms latency per request, measured with
perf_kit.repeat_and_time.timing)The test script is as following:
Details
However, I found it hard to reproduce the production environment as described in #69041... I would really appreciate it if someone could help check if this really solved the problem.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code Opus 4.8 following the guidelines, reviewed by @Andrushika.
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.