Add team_name tag to Edge executor sync metric#69005
Merged
Merged
Conversation
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
I have left some comments.
ferruzzi
reviewed
Jun 26, 2026
ferruzzi
reviewed
Jun 26, 2026
shivaam
force-pushed
the
codex/edge-executor-metrics-68996
branch
from
June 27, 2026 01:49
76c4ef4 to
cb85313
Compare
Contributor
Author
|
Thanks @ferruzzi @SameerMesiah97 . I updated the PR to match the existing Edge executor multi-team test pattern:
|
SameerMesiah97
approved these changes
Jun 28, 2026
ferruzzi
approved these changes
Jun 29, 2026
ferruzzi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for taking this on.
1 task
eladkal
approved these changes
Jun 30, 2026
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
* Add team name tag to Edge executor sync metric * Address Edge executor metric test review
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
team_nametag to the Edge executor sync duration metric for multi-team deployments.This follows the same pattern as #68593 for executor metrics:
self.team_nameas the metric tag sourceprune_dictso global/no-team executors keep the existing empty tag setThis PR covers the
edge_executor.sync.durationitem from #68996. Edge worker metrics and ECS executor metrics are being kept in separate PRs.Tests:
uv run ruff format --check providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py providers/edge3/tests/unit/edge3/executors/test_edge_executor.pyuv run ruff check providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py providers/edge3/tests/unit/edge3/executors/test_edge_executor.pygit diff --checkuv run pytest providers/edge3/tests/unit/edge3/executors/test_edge_executor.py -qbreeze run pytest providers/edge3/tests/unit/edge3/executors/test_edge_executor.py -quvx prek run --from-ref upstream/main --stage pre-commitResults:
20 passed, 1 warningRelated: #68996
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines
Drafted-by: OpenAI Codex (no human review before posting)