Skip to content

[AIP-94] Mark connections commands as migrated to airflowctl#68972

Merged
henry3260 merged 2 commits into
apache:mainfrom
yuseok89:migrate-connections-to-airflowctl
Jul 5, 2026
Merged

[AIP-94] Mark connections commands as migrated to airflowctl#68972
henry3260 merged 2 commits into
apache:mainfrom
yuseok89:migrate-connections-to-airflowctl

Conversation

@yuseok89

@yuseok89 yuseok89 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

related: #68402

Marks the migratable connections CLI commands (list, add, delete, test, create-default-connections, import) with the maintainer-facing @deprecated_for_airflowctl marker, per the converted direction in #68402. Existing implementations are unchanged.
connections import is left out for now. It has no airflowctl equivalent yet.

Someone mentioned picking up connections in #68402, but I didn't see a PR after 2+ weeks, so I went ahead with this. Happy to coordinate or step back if it's already in progress.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    • Opus 4.8

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@yuseok89
yuseok89 marked this pull request as ready for review June 25, 2026 13:58

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@henry3260

Copy link
Copy Markdown
Contributor

I think we have airflowctl connections import now

def import_(args, api_client=NEW_API_CLIENT) -> None:

@yuseok89
yuseok89 force-pushed the migrate-connections-to-airflowctl branch 2 times, most recently from e8423de to 55c90a9 Compare June 27, 2026 14:14
@yuseok89

Copy link
Copy Markdown
Contributor Author

I think we have airflowctl connections import now

Good catch.
I missed that one.
Thanks for the heads-up!

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 2, 2026
@Prab-27

Prab-27 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@yuseok89 Happy to see this !

I was woking on it but busy on fixing failed prek hook - env and other
Thanks !!

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — verified the six connections commands match the tracked set (#68402), the airflowctl replacement strings are correct, and the marker is a no-op attribute setter. Thanks.

@potiuk

potiuk commented Jul 4, 2026

Copy link
Copy Markdown
Member

You need to resolve merge conflicts though.

@yuseok89
yuseok89 force-pushed the migrate-connections-to-airflowctl branch from 55c90a9 to 916d56e Compare July 5, 2026 08:25
@henry3260 henry3260 added the backport-to-v3-3-test Backport to v3-3-test label Jul 5, 2026
@henry3260
henry3260 merged commit cf28061 into apache:main Jul 5, 2026
73 checks passed
@github-actions github-actions Bot added this to the Airflow 3.3.1 milestone Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.1 based on: backport label targeting v3-3-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 5, 2026
…ctl (apache#68972)

(cherry picked from commit cf28061)

Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 5, 2026
…ctl (apache#68972)

(cherry picked from commit cf28061)

Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
potiuk pushed a commit that referenced this pull request Jul 5, 2026
…ctl (#68972) (#69410)

(cherry picked from commit cf28061)

Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Jul 7, 2026
…ctl (#68972) (#69410)

(cherry picked from commit cf28061)

Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Jul 9, 2026
…ctl (#68972) (#69410)

(cherry picked from commit cf28061)

Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI backport-to-v3-3-test Backport to v3-3-test ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants