Percent-encode API client path params#68667
Merged
Merged
Conversation
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
June 17, 2026 09:39
Member
Author
BeforeScreen.Recording.2026-06-17.at.11.42.07.movAfterScreen.Recording.2026-06-17.at.11.39.54.mov |
pierrejeambrun
force-pushed
the
encode-ui-api-path-params
branch
from
June 17, 2026 09:45
d85c33b to
210e24a
Compare
ashb
approved these changes
Jun 17, 2026
1 task
pierrejeambrun
added a commit
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable keys may start with or contain
/(e.g./foo). The generated UI API client interpolated path params withencodeURI, which intentionally leaves/unescaped — so a key/fooproduced a literal//in the URL (/api/v2/variables//foo). Some proxies collapse//→/, silently dropping the slash and corrupting the key, so GET/PATCH/DELETE of such variables fail behind those proxies (create is unaffected, since the key travels in the request body).Switching
OpenAPI.ENCODE_PATHtoencodeURIComponentescapes/as%2F, so no literal//ever appears; the backend decodes it back to/. It's a no-op for plain keys, and also correctly escapes other characters (?,#,&, …) thatencodeURIwrongly left untouched in path-param values.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines