Instruct agents to reduce direct AirflowException usage#68656
Merged
shahar1 merged 1 commit intoJun 17, 2026
Conversation
Make explicit on both the authoring and review sides that direct AirflowException raises are being reduced, not added. New direct usages are disallowed (already enforced by the check-no-new-airflow-exceptions prek hook), and the reviewer guidance clarifies that the only acceptable movement of an AirflowException line is relocating an already-existing one verbatim during a refactor, which is not a new usage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shahar1
requested review from
amoghrajesh,
ashb,
choo121600,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
June 17, 2026 05:20
Contributor
Author
|
Idea: Flow example:
|
Lee-W
approved these changes
Jun 17, 2026
amoghrajesh
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Summary
I've noticed that agent created PRs still use
raise AirflowExceptiondirectly, which might indicate a bug in the corresponding pre-commit (should be handled separately) - but it would be also nice to enforce it from the agent's side as well.AI Summary
Make explicit on both the authoring and review sides that direct AirflowException raises are being reduced, not added. New direct usages are disallowed (already enforced by the check-no-new-airflow-exceptions prek hook), and the reviewer guidance clarifies that the only acceptable movement of an AirflowException line is relocating an already-existing one verbatim during a refactor, which is not a new usage.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.