Skip to content

Test connections via workers instead of the API server#68113

Draft
anishgirianish wants to merge 2 commits into
apache:mainfrom
anishgirianish:ui-async-connection-test
Draft

Test connections via workers instead of the API server#68113
anishgirianish wants to merge 2 commits into
apache:mainfrom
anishgirianish:ui-async-connection-test

Conversation

@anishgirianish

@anishgirianish anishgirianish commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Follow-up to #62343, which moved connection testing to workers but left the UI on the old sync endpoint.

This wires the Connections "Test" button to the new worker flow: enqueue the test, then poll until it finishes. The result shows up as a toast (with the worker's message) and the usual green/red icon. Clicking Test while one is already running shows an "already in progress" message.

related: #62343


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Note

✅ Ready for review · @anishgirianish@potiuk · 2026-06-12 13:30 UTC

Thanks @anishgirianish — all checks are green and this PR is marked ready for maintainer review. The ball is with the maintainers now; a maintainer will take the next look.

Automated triage — may be imperfect.

@boring-cyborg boring-cyborg Bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default labels Jun 5, 2026
@anishgirianish anishgirianish marked this pull request as ready for review June 11, 2026 01:20
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jun 12, 2026

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, tested and working as expected.

I don't think we can do this before all executor support the async connection testing flow. Otherwise it will just break the feature for people using the celery executor for instance.

We also need to update the documentation, for instance here /Users/pierrejeambrun/Documents/astronomer/git-repositories/airflow-agents/agent-1/airflow-core/docs/howto/connection.rst,

When testing in the Airflow UI, the test executes from the webserver so this feature is subject to network egress rules setup for your webserver.

For security reasons, the test connection functionality is disabled by default across Airflow UI, API

Etc...

Also a few suggestions / comments.

Comment thread airflow-core/src/airflow/ui/public/i18n/locales/en/admin.json Outdated
Comment thread airflow-core/src/airflow/ui/src/pages/Connections/TestConnectionButton.tsx Outdated
Comment thread airflow-core/src/airflow/ui/src/queries/useTestConnection.ts Outdated
Comment thread airflow-core/src/airflow/ui/src/queries/useTestConnection.ts Outdated
Comment thread airflow-core/src/airflow/ui/src/queries/useTestConnection.ts Outdated
@pierrejeambrun pierrejeambrun changed the title UI: Test connections via workers instead of the API server Test connections via workers instead of the API server Jun 22, 2026
@anishgirianish anishgirianish force-pushed the ui-async-connection-test branch from af35cfc to 26d9b88 Compare June 22, 2026 23:49
@anishgirianish

Copy link
Copy Markdown
Contributor Author

@pierrejeambrun thank you so much for the review. I have addressed the feedback relating to this pr. And thank you very much for pointing out the executor work for supporting async connection. I will covert this pr to draft for now and will start working on the executor work.

thank you

@anishgirianish anishgirianish marked this pull request as draft June 23, 2026 01:34
@potiuk

potiuk commented Jul 8, 2026

Copy link
Copy Markdown
Member

Note

🛠️ Maintainer triage note for @anishgirianish · by @potiuk · 2026-07-08 16:05 UTC

This draft has been inactive for ~16 days, so I'm closing it to keep the review queue tidy — no judgment on the work itself.

No rush — reopen it (or open a fresh PR) whenever you're ready to continue; nothing is lost.

Automated triage — may be imperfect; a maintainer takes the next look.

@potiuk potiuk closed this Jul 8, 2026
@pierrejeambrun pierrejeambrun reopened this Jul 9, 2026
@pierrejeambrun

Copy link
Copy Markdown
Member

Not stale, it just needs some other preliminary work on the executors before it can go through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. ready for maintainer review Set after triaging when all criteria pass. translation:default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants