Skip to content

Isolate openlineage extractor test from hook lineage collector pollution #67057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 1 commit into from
May 17, 2026
Merged

Isolate openlineage extractor test from hook lineage collector pollution #67057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions providers/openlineage/tests/unit/openlineage/extractors/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,25 @@ def test_default_extractor_uses_different_operatorlineage_class():


def test_default_extractor_uses_wrong_operatorlineage_class():
operator = OperatorWrongOperatorLineageClass(task_id="task_id")
# If extractor returns lineage class that can't be changed into OperatorLineage, just return
# empty OperatorLineage
assert ExtractorManager().extract_metadata(mock.MagicMock(), operator, None, None) == OperatorLineage()
# The hook lineage collector is a process-wide singleton; other tests in the same
# pytest session (e.g. providers/common/ai/.../durable/test_storage.py via
# ObjectStoragePath operations) populate it, and ExtractorManager.extract_metadata
# falls through to it when the extractor returns an unusable lineage class, leaking
# those datasets into this assertion. Pin a fresh collector for isolation. Durable
# fix (clearing the collector in teardown for tests that exercise ObjectStoragePath)
# is tracked at https://github.com/apache/airflow/issues/67044.
from airflow.providers.common.compat.sdk import HookLineageCollector

with mock.patch(
"airflow.providers.common.compat.lineage.hook.get_hook_lineage_collector",
return_value=HookLineageCollector(),
):
operator = OperatorWrongOperatorLineageClass(task_id="task_id")
# If extractor returns lineage class that can't be changed into OperatorLineage,
# just return empty OperatorLineage
assert (
ExtractorManager().extract_metadata(mock.MagicMock(), operator, None, None) == OperatorLineage()
)


def test_operator_lineage_merge_concatenates_inputs_and_outputs():
Expand Down
Loading