fix(amazon): extend SQS QUEUE_REGEXP to match AWS China endpoints#65173
Merged
Conversation
The QUEUE_REGEXP only matched standard amazonaws.com domains, causing SqsMessageQueueProvider.queue_matches() to return False for China region queue URLs (amazonaws.cn). Added amazonaws.cn as an alternate domain in the regex to support cn-north-1 and cn-northwest-1 regions. Fixes apache#65128 Signed-off-by: Ali <alliasgher123@gmail.com>
vincbeck
approved these changes
Apr 14, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
thanks for quick fix. |
alliasgher
added a commit
to alliasgher/airflow
that referenced
this pull request
Apr 15, 2026
Follow-up to apache#65173. AWS China regions use the endpoint suffix amazonaws.com.cn, not amazonaws.cn. The regex shipped in apache#65173 fails to match real AWS China SQS URLs like: https://sqs.cn-northwest-1.amazonaws.com.cn/123456/my-sqs Update the regex to accept the optional .cn suffix on amazonaws.com, and update the tests to use the correct endpoint. Reported by @crazy-canux in apache#65128.
vincbeck
pushed a commit
that referenced
this pull request
Apr 15, 2026
) Follow-up to #65173. AWS China regions use the endpoint suffix amazonaws.com.cn, not amazonaws.cn. The regex shipped in #65173 fails to match real AWS China SQS URLs like: https://sqs.cn-northwest-1.amazonaws.com.cn/123456/my-sqs Update the regex to accept the optional .cn suffix on amazonaws.com, and update the tests to use the correct endpoint. Reported by @crazy-canux in #65128.
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Apr 16, 2026
…che#65299) Follow-up to apache#65173. AWS China regions use the endpoint suffix amazonaws.com.cn, not amazonaws.cn. The regex shipped in apache#65173 fails to match real AWS China SQS URLs like: https://sqs.cn-northwest-1.amazonaws.com.cn/123456/my-sqs Update the regex to accept the optional .cn suffix on amazonaws.com, and update the tests to use the correct endpoint. Reported by @crazy-canux in apache#65128.
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
QUEUE_REGEXPonly matchedamazonaws.comdomains, soSqsMessageQueueProvider.queue_matches()returnedFalsefor AWS China region URLs such as:Extends the regex to accept
amazonaws.cnas an alternate domain suffix, supporting China regionscn-north-1andcn-northwest-1.Fixes #65128
Are there any user-facing changes?
SQS queue URLs in AWS China regions are now correctly recognised by the
SqsMessageQueueProvider.Checklist
cn-north-1andcn-northwest-1China region URLs intest_message_sqs_queue_matchesSigned-off-by: Ali alliasgher123@gmail.com