Feat: Adding task-level filters to DAG view in graph tab

[itayweb]

Adding new task-level filters to use on DAG view graph tab

• closes: [Filters] Add task-level filters to DAG View - Graph tab #53044

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

Generated-by: Claude Code following the guidelines

[bbovenzi]

The other filters in this dropdown are backend. So let's not mix the two.

I wonder if this would be better to detect the ctrl-f hotkey, give these search params and a user can tab through the matching tasks

[itayweb]

The other filters in this dropdown are backend. So let's not mix the two.

I wonder if this would be better to detect the ctrl-f hotkey, give these search params and a user can tab through the matching tasks

Oh I see.. do you prefer I'll move the new filters I've added to the options button?
Regarding the ctrl-f, you meant user can search operators/status/etc.. and it will auto filter the dag view?

[bbovenzi]

The other filters in this dropdown are backend. So let's not mix the two.
I wonder if this would be better to detect the ctrl-f hotkey, give these search params and a user can tab through the matching tasks

Oh I see.. do you prefer I'll move the new filters I've added to the options button? Regarding the ctrl-f, you meant user can search operators/status/etc.. and it will auto filter the dag view?

I don't want to throw more in the setting dropdown. I think we need to rethink the UX given all the features to navigate both the grid, gantt and graph are now. This could be its own Search Icon button perhaps?

And yes, if you already focused on the graph view then ctrl-f will also open that search

[itayweb]

The other filters in this dropdown are backend. So let's not mix the two.
I wonder if this would be better to detect the ctrl-f hotkey, give these search params and a user can tab through the matching tasks

Oh I see.. do you prefer I'll move the new filters I've added to the options button? Regarding the ctrl-f, you meant user can search operators/status/etc.. and it will auto filter the dag view?

I don't want to throw more in the setting dropdown. I think we need to rethink the UX given all the features to navigate both the grid, gantt and graph are now. This could be its own Search Icon button perhaps?

And yes, if you already focused on the graph view then ctrl-f will also open that search

Done 👍

[bbovenzi]

Can you also update the screenshot to reflect the latest changes? Also, I'd love to see a video or gif.

[bbovenzi]

A bunch of small edits. But the major change I would like to see is to reduce the number of times we are walking through the dag structure's nested NodeResponse. We already do it for useOpenGroups. The best approach is probably to rename that useGroups() and have that hook handle all of these actions, because then we could have the same functionality happen in the grid view too.

[bbovenzi]

Actually the performance looks fine for now while we need to do virtualization for the graph view.

In manual testing, the only issue I noticed was that the filters were also filtering the task instances list on the right hand side of the page. We should make the search param keys different. Maybe later we can make this all integrated but that is much more work.

[bbovenzi]

Looking better. Two comments

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.