Skip to content

fix: quote reserved MySQL keyword 'interval' in deadline_alert migration queries #63494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vatsrahul1001 merged 1 commit into from
Mar 17, 2026
Merged

fix: quote reserved MySQL keyword 'interval' in deadline_alert migration queries #63494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions airflow-core/src/airflow/migrations/versions/0101_3_2_0_ui_improvements_for_deadlines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,15 @@
DEFAULT_BATCH_SIZE = 1000
ENCODING_TYPE = "deadline_alert"

deadline_alert_table = sa.table(
"deadline_alert",
sa.column("reference"),
sa.column("interval"),
sa.column("callback_def"),
sa.column("id"),
sa.column("serialized_dag_id"),
)


def upgrade() -> None:
"""Make changes to enable adding DeadlineAlerts to the UI."""
Expand Down Expand Up @@ -280,11 +289,11 @@ def validate_written_data(
# disable validation for large deployments where performance is critical??

validation_result = conn.execute(
sa.text("""
SELECT reference, interval, callback_def
FROM deadline_alert
WHERE id = :alert_id
"""),
sa.select(
deadline_alert_table.c.reference,
deadline_alert_table.c.interval,
deadline_alert_table.c.callback_def,
).where(deadline_alert_table.c.id == sa.bindparam("alert_id")),
{"alert_id": deadline_alert_id},
).fetchone()

Expand Down Expand Up @@ -661,11 +670,11 @@ def migrate_deadline_alert_data_back_to_serialized_dag() -> None:
restored_deadline_objects = []

alert_result = conn.execute(
sa.text("""
SELECT reference, interval, callback_def
FROM deadline_alert
WHERE serialized_dag_id = :serialized_dag_id
"""),
sa.select(
deadline_alert_table.c.reference,
deadline_alert_table.c.interval,
deadline_alert_table.c.callback_def,
).where(deadline_alert_table.c.serialized_dag_id == sa.bindparam("serialized_dag_id")),
{"serialized_dag_id": serialized_dag_id},
).fetchall()

Expand Down
Loading