Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow-core/newsfragments/63205.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix grid view URL for dynamic task groups producing 404 by not appending ``/mapped`` to group URLs.
19 changes: 17 additions & 2 deletions airflow-core/src/airflow/ui/src/utils/links.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ describe("buildTaskInstanceUrl", () => {
}),
).toBe("/dags/new_dag/runs/new_run/tasks/group/new_group");

// Groups should never preserve tabs even for mapped groups
// Groups should never get /mapped appended — no such route exists for task groups
expect(
buildTaskInstanceUrl({
currentPathname: "/dags/old/runs/old/tasks/group/old_group/events",
Expand All @@ -254,6 +254,21 @@ describe("buildTaskInstanceUrl", () => {
runId: "new_run",
taskId: "new_group",
}),
).toBe("/dags/new_dag/runs/new_run/tasks/group/new_group/mapped/3");
).toBe("/dags/new_dag/runs/new_run/tasks/group/new_group");
});

it("should not append /mapped for dynamic task groups from grid view", () => {
// Regression test for https://github.com/apache/airflow/issues/63197
// Dynamic task groups have isMapped=true but no route exists for group/:groupId/mapped
expect(
buildTaskInstanceUrl({
currentPathname: "/dags/my_dag/runs/run_1/tasks/group/my_group",
dagId: "my_dag",
isGroup: true,
isMapped: true,
runId: "run_1",
taskId: "my_group",
}),
).toBe("/dags/my_dag/runs/run_1/tasks/group/my_group");
});
});
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/src/utils/links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export const buildTaskInstanceUrl = (params: {

let basePath = `/dags/${dagId}/runs/${runId}/tasks/${groupPath}${taskId}`;

if (isMapped) {
if (isMapped && !isGroup) {
basePath += `/mapped`;
if (mapIndex !== undefined && mapIndex !== "-1") {
basePath += `/${mapIndex}`;
Expand Down
Loading