Skip to content

Do not get logout_callback_url from request in keycloak auth manager #62795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Mar 3, 2026
Merged

Do not get logout_callback_url from request in keycloak auth manager #62795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions providers/keycloak/src/airflow/providers/keycloak/auth_manager/routes/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
import json
import logging
from typing import cast
from urllib.parse import quote
from urllib.parse import quote, urljoin

from fastapi import Request # noqa: TC002
from fastapi.responses import HTMLResponse, RedirectResponse

from airflow.api_fastapi.app import get_auth_manager
from airflow.api_fastapi.app import AUTH_MANAGER_FASTAPI_APP_PREFIX, get_auth_manager
from airflow.api_fastapi.auth.managers.base_auth_manager import COOKIE_NAME_JWT_TOKEN
from airflow.providers.keycloak.version_compat import AIRFLOW_V_3_1_1_PLUS

Expand Down Expand Up @@ -110,7 +110,8 @@
end_session_endpoint = keycloak_config["end_session_endpoint"]

id_token = request.cookies.get(COOKIE_NAME_ID_TOKEN)
post_logout_redirect_uri = request.url_for("logout_callback")
base_url = conf.get("api", "base_url", fallback="/")
post_logout_redirect_uri = urljoin(base_url, f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/logout_callback")

if id_token:
encoded_id_token = quote(id_token, safe="")
Expand All @@ -128,7 +129,7 @@
def logout_callback(request: Request):
"""
Complete the log-out.

Check warning

Code scanning / CodeQL

URL redirection from remote source Medium

Untrusted URL redirection depends on a
user-provided value
Loading
.
This callback is redirected by Keycloak after the user has been logged out from Keycloak.
"""
login_url = get_auth_manager().get_url_login()
Expand Down
4 changes: 2 additions & 2 deletions providers/keycloak/tests/unit/keycloak/auth_manager/routes/test_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ def test_login_callback_without_code(self, client):
@pytest.mark.parametrize(
("id_token", "logout_callback_url"),
[
(None, "http://testserver/auth/logout_callback"),
(None, "/auth/logout_callback"),
(
"id_token",
"logout_url?post_logout_redirect_uri=http://testserver/auth/logout_callback&id_token_hint=id_token",
"logout_url?post_logout_redirect_uri=/auth/logout_callback&id_token_hint=id_token",
),
],
)
Expand Down