Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Nice. Overall looking good.
Just a few suggestions/nits
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/dag_run.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/dag_run.py
Outdated
Show resolved
Hide resolved
8a6c6a7 to
2714195
Compare
|
Thanks for the review! UpdateI think that I just misread the router pattern and used the wrong bulk body type, I just change to the correct one mention in the suggestion |
pierrejeambrun
left a comment
There was a problem hiding this comment.
With the way how this is currently implemented. It doesn't seem possible to delete multiple runs from multiple dag_ids at the same time. Which kind of defeat the purpose.
If you take a look at the 'bulk' operation on TIs bulk_task_instances you'll get an idea of how we can rework this to achieve this.
Also feel free to 'mark as resolved' conversation you have addressed.
|
@Pei-Cheng-Yu This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack. |
57ce9e9 to
b16ac42
Compare
|
Thanks, I understand now. I followed the earlier suggestion and interpreted it in a way using I should have stopped and clarified the direction when that became ambiguous. I just rework it to align with the |
why
related #52439
according disscussion in PR
we need a bulkdelete endpoint for dag run
how
I implemented this by referencing the existing bulk action implementations in:
task_instance.pyconnection.pyvariable.pyWas generative AI tooling used to co-author this PR?
Generated-by: [OpenAI Codex / GPT-5 ] following the guidelines
for ideation and partial code generation. I reviewed and adjusted the changes to align with existing implementations of corresponding bulk actions elsewhere, and verified they pass
prek.I make sure that codex only modify the right part of code, and any thing about endpoint that requiring codegen were regenerated with
prekand then pass the local prek test{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.