KubernetesPodOperator check xcom sidecar running before trying to read xcom#60319
Conversation
|
Looks good to me overall. This is a tightly scoped, minimal fix with a new test ( The existing tests already cover the The only non-blocking suggestion I have is to mention these test additions/adjustments in the PR description, as that context helps reduce review friction. And, for future reference, I would advise you to squash commit when you rebase with one descriptive commit if the change is relatively minor. No need to do this now as there might be requests for changes. |
No, in my view squashing is not needed. During merge all commits are squashed so if more commits are coming it is fine to collect and rebase. In my even makes it simpler in a re-review what has been changed after last review cycle. If always all commits are squashed I always need to make a full review... |
…d xcom (apache#60319) * check sidecar running before trying to read xcom * Rename test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…d xcom (apache#60319) * check sidecar running before trying to read xcom * Rename test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…d xcom (apache#60319) * check sidecar running before trying to read xcom * Rename test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…d xcom (apache#60319) * check sidecar running before trying to read xcom * Rename test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…d xcom (apache#60319) * check sidecar running before trying to read xcom * Rename test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…d xcom (apache#60319) * check sidecar running before trying to read xcom * Rename test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
Overview
We observed Kubernetes API errors in KubernetesPodOperator when a pod is evicted. In this state the xcom sidecar container has already terminated, so exec/read attempts fail. The previous exception did not clearly indicate that the sidecar was no longer running, making it hard to understand why no XCom output could be read. The new exception message explicitly states that the sidecar is not running, clarifying why XCom retrieval failed.
Change Summary