Skip to content

Remove global from conftest#59696

Merged
potiuk merged 1 commit intoapache:mainfrom
jscheffl:bugfix/remove-global-from-conftest
Dec 21, 2025
Merged

Remove global from conftest#59696
potiuk merged 1 commit intoapache:mainfrom
jscheffl:bugfix/remove-global-from-conftest

Conversation

@jscheffl
Copy link
Copy Markdown
Contributor

Another small increment to remove global statements for PR #58116

This removes global statement from two conftest.py implementations which are similar. Wrapping into a private class with a static field instead of global.
Bonus added some typing hints on-top

global is evil. Might not be critical in conftest but keep code clean :-D

@potiuk potiuk merged commit 60a5eb4 into apache:main Dec 21, 2025
58 checks passed
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants