Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice, looks super promising!
|
As long as it's not |
|
On a big grid view "Interaction to Next Paint" went from 456ms to 168ms. So looks like the automatic caching is better than our manual efforts! |
28a7d48 to
4eb3d5c
Compare
|
Excited to see this and about the performance optimization. |
3ac447b to
3a786d0
Compare
airflow-core/src/airflow/ui/src/components/DataTable/FilterMenuButton.tsx
Show resolved
Hide resolved
|
Going to merge this after #60241 to make cherry picking and rebasing easier |
deba9bd to
9a5776b
Compare
|
Just rebased with the virtualization PR. grid view performance seems to hold even without any manual effort! |
9a5776b to
faeb0f1
Compare
Rebase and fix linting Restore necessary memoization Fix daterangefilter test Add hooks/todo linting
faeb0f1 to
83c0649
Compare
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker d026685 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
* Add react compiler Rebase and fix linting Restore necessary memoization Fix daterangefilter test Add hooks/todo linting * Remove memos and callbacks from Grid
|
Needs manual backport I believe if we want that in 3.1.7 |
|
Yeah, I am working on a manual backport. Its not necessarily needed for 3.1.7. But it will make other backports much easier |
|
Let's leave this for 3.2 actually. We didn't backport React 19 either. So its a larger surface area than I want to mess with for now |
* Add react compiler Rebase and fix linting Restore necessary memoization Fix daterangefilter test Add hooks/todo linting * Remove memos and callbacks from Grid
* Add react compiler Rebase and fix linting Restore necessary memoization Fix daterangefilter test Add hooks/todo linting * Remove memos and callbacks from Grid
* Add react compiler Rebase and fix linting Restore necessary memoization Fix daterangefilter test Add hooks/todo linting * Remove memos and callbacks from Grid
* Add react compiler Rebase and fix linting Restore necessary memoization Fix daterangefilter test Add hooks/todo linting * Remove memos and callbacks from Grid
* Add react compiler Rebase and fix linting Restore necessary memoization Fix daterangefilter test Add hooks/todo linting * Remove memos and callbacks from Grid
With React 19 having stable React Compiler support we can switch to it and remove all of our own manual
useMemoanduseCallbackcode.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.