Replace the "postgres" extra on pandas from Presto provider with direct psycopg2-binary#57813
Merged
Replace the "postgres" extra on pandas from Presto provider with direct psycopg2-binary#57813
Conversation
rawwar
approved these changes
Nov 4, 2025
potiuk
reviewed
Nov 4, 2025
a6e1069 to
060f0e3
Compare
060f0e3 to
0fc9068
Compare
potiuk
approved these changes
Nov 4, 2025
0fc9068 to
2a1f933
Compare
Member
|
Rebased .. we had two cross-merged PRs that broke main |
This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in #57141
2a1f933 to
b42f6bf
Compare
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…ct psycopg2-binary. (apache#57813) This was pulling in psycopg2, but out own postres provider uses psycopg2-binary which is essentially in conflict. Since this wasn't behind an extra, and not every user needs it, _and_ since it conflicts with our own postgres deps, I think removal is the best option. This was only recently added/made working in apache#57141 (before then it issued a warning about an unknown extra) But some things have an implicit dep on Psycopg2 being available, so we depend directly on the (correct for us) psycopg2-binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was pulling in psycopg2, but out own postres provider uses
psycopg2-binary which is essentially in conflict.
Since this wasn't behind an extra, and not every user needs it, and since it
conflicts with our own postgres deps, I think removal is the best option.
This was only recently added/made working in #57141
The error this caused was on my local machine where pg_config is not installed:
(That last part was actually incorrect, it is not weaviate that depended on the extra, but presto)