Fix: Handle SQLAlchemy_URI for Apache Impala #57153
Merged
jason810496 merged 7 commits intoapache:mainfrom Oct 28, 2025
Pyasma:fix/Impala-Hook-URI
Merged
Fix: Handle SQLAlchemy_URI for Apache Impala #57153jason810496 merged 7 commits intoapache:mainfrom Pyasma:fix/Impala-Hook-URI
jason810496 merged 7 commits intoapache:mainfrom
Pyasma:fix/Impala-Hook-URI
Conversation
Contributor
Author
|
@jason810496 @Lee-W can you please review this PR |
KoviAnusha
reviewed
Oct 24, 2025
17 tasks
Lee-W
reviewed
Oct 25, 2025
Lee-W
reviewed
Oct 26, 2025
Member
Lee-W
left a comment
There was a problem hiding this comment.
a few nits. not major issue. great job!
Lee-W
approved these changes
Oct 27, 2025
Contributor
Author
|
Hey @jason810496 can you review this PR? |
jason810496
approved these changes
Oct 27, 2025
eladkal
approved these changes
Oct 28, 2025
Contributor
eladkal
left a comment
There was a problem hiding this comment.
happy to merge if no other concerns
odaneau-astro
pushed a commit
to odaneau-astro/airflow
that referenced
this pull request
Mar 18, 2026
* Added SQL alchemy compatible code in impala.py * Updating Test * adding two test * Completed test * Finish writing test * Impala-hook * changed Not in -> !=
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a SQLAlchemy-compatible sqlalchemy_url property in ImpalaHook.
Added get_uri() method to return a fully formatted URI for Impala connections.
Added unit tests to verify correctness of the sqlalchemy_url property and get_uri() output.
Ran prek pre-commit checks to ensure code quality and formatting.
Related : #38195
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.