i18n: Move translations to `ui/public` and enable dynamic loading to reduce bundle size by choo121600 · Pull Request #51735 · apache/airflow

choo121600 · 2025-06-14T15:46:21Z

Summary

Moved all translation (i18n) files from ui/src/i18n/locales to ui/public/i18n/locales.
Adopted i18next-http-backend to load translation files via HTTP dynamically.
Updated FastAPI static file serving logic to ensure translation files are accessible in both dev and prod environments.
- Unified i18next loadPath to /static/i18n/locales/{{lng}}/{{ns}}.json for both environments.
Improved maintainability and scalability of the i18n system.

Details

i18next-http-backend allows translation files to be loaded on demand, reducing the initial bundle size and supporting dynamic language/namespace loading.
FastAPI dev mode now mounts the public i18n directory to /static/i18n, ensuring translation files are served correctly during development.
Production mode continues to serve translation files from the built dist directory.
The i18n config (config.ts) was updated to use a unified HTTP path for translation files, simplifying the frontend logic.

Before

✓ 3627 modules transformed.
dist/.vite/manifest.json                0.45 kB │ gzip:     0.21 kB
dist/index.html                         0.50 kB │ gzip:     0.32 kB
dist/assets/FailedLogs-BGPSeqnE.js      1.70 kB │ gzip:     0.90 kB
dist/assets/index-DQ137obh.js       4,359.84 kB │ gzip: 1,301.55 kB

After

✓ 3589 modules transformed.
dist/index.html                               0.50 kB │ gzip:     0.32 kB
dist/.vite/manifest.json                      0.69 kB │ gzip:     0.25 kB
dist/assets/FailedLogs-BKux9o7Z.js            1.70 kB │ gzip:     0.90 kB
dist/assets/browser-ponyfill-BvFGHPkG.js     10.26 kB │ gzip:     3.50 kB
dist/assets/index-C6hLGF4h.js             4,268.63 kB │ gzip: 1,269.05 kB

Breaking Changes

If we have custom scripts or tools that expect translation files in src, please update them to use the new location in public/i18n/locales.

closes: #51123

Opened a new PR to avoid potential issues with translation file conflicts in the previous one.
Sorry for the inconvenience.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good for me (except one sanity question)

jscheffl · 2025-06-14T16:09:46Z

Looks good for me (except one sanity question)

(as wel as CI needs to turn green :-D)

ashb

You have a lot of unrelated changes which makes the diff hard to review

…aces

…slint rule" This reverts commit d218738.

choo121600 · 2025-06-19T20:34:58Z

I don't understand why this Tests AMD / Airflow CTL tests / airflow-ctl:P3.9 tests (pull_request) CI suddenly started failing.

choo121600 · 2025-06-20T02:13:43Z

Resolved conflicts in translation files and applied i18nRules.
- Previously, i18nRules were not applied, so formatting was inconsistent. In this commits, applying the rules resulted in automatic formatting corrections in some translation files.
Moved check_translations_completeness.py to dev/i18n/check_translations_completeness.py.
- Since this script is a development tool, having it under public was inappropriate. I moved it to the dev directory instead. If you think there's a better location, feel free to suggest it.
Initially, I planned to move public/i18n/README.md along with the script to dev,
but since it could reduce visibility and accessibility for translation contributors, I decided to keep it in public.
I also updated the command path in section "8.1. Checking completeness of i18n files" to reflect the script location.

choo121600 · 2025-06-20T03:30:42Z

@pierrejeambrun , Thank you for reviewing my PR ;)

I’ve resolved all the conflicts, and as previously discussed,
I went ahead and moved the check_translations_completeness.py script under dev/i18n instead of leaving it in ui/public/i18n, since this wasn’t fully decided in the discussion but seemed like a better fit (and having a dev script inside the ui directory felt a bit out of place as well).

The CI checks for these changes have also just passed.

potiuk

Fantastic !

potiuk · 2025-06-20T06:43:42Z

Wooohooo !

choo121600 · 2025-06-20T08:15:38Z

Finally!
Huge thanks to everyone who helped review this PR ;)

pierrejeambrun

Good job! #protm

…reduce bundle size (apache#51735) * Feat(i18n): Move translation files to public, use i18next-http-backend * Adopted i18next-http-backend * Fix(i18n): Update locales directory path to public for translation files * Fix(i18n): Update static file path for translation locales * Fix(i18n): Update translation config file path * Fix(i18n): Update ESLint configuration to include jsonc-parser * Fix(i18n): Update ESLint file patterns and add 'components' to namespaces * Fix(i18n): Initialize i18n(en) in DagCard tests * chore: enforce consistent array type syntax per @typescript-eslint rule * Revert "chore: enforce consistent array type syntax per @typescript-eslint rule" This reverts commit d218738. * Fix(i18n): Ignore i18n locale files in ESLint TypeScript rules * Fix(tests): Remove unused imports and clean up test setup * Apply pre-commit formatting to openapi-gen/ files as per apache#51755 * Fix(eslint): Update i18n and TypeScript rules configuration * Apply ESLint and i18nRule * Mov Arabic and French translations to public * Fix: Update translation file paths to public directory * Moved i18n doc and completeness checker script from public to dev/i18n * fix(i18n): i18n policy document translation completeness check command

choo121600 requested review from BasPH, Lee-W, ashb, bbovenzi, bugraoz93, eladkal, ephraimbuddy, gopidesupavan, jason810496, jscheffl, kaxil, mobuchowski, pierrejeambrun, potiuk, rawwar, romsharon98, ryanahamilton, shahar1 and shubhamraj-git as code owners June 14, 2025 15:46

boring-cyborg bot added area:API Airflow's REST/HTTP API area:dev-tools area:UI Related to UI/UX. For Frontend Developers. labels Jun 14, 2025

jscheffl approved these changes Jun 14, 2025

View reviewed changes

Comment thread .pre-commit-config.yaml

Comment thread airflow-core/src/airflow/api_fastapi/core_api/app.py Outdated

nailo2c mentioned this pull request Jun 14, 2025

remove test_serde_serialize_recursion_limit to fix ci #51737

Merged

choo121600 force-pushed the feature/i18n-http-backend branch 2 times, most recently from 1105721 to f82036d Compare June 14, 2025 21:45

ashb reviewed Jun 15, 2025

View reviewed changes

Comment thread airflow-core/src/airflow/ui/openapi-gen/queries/queries.ts

ashb reviewed Jun 15, 2025

View reviewed changes

Comment thread airflow-core/src/airflow/ui/openapi-gen/requests/core/CancelablePromise.ts Outdated

Comment thread airflow-core/src/airflow/ui/openapi-gen/requests/core/OpenAPI.ts Outdated

choo121600 force-pushed the feature/i18n-http-backend branch from cf338f9 to e09be62 Compare June 15, 2025 07:39

choo121600 added 10 commits June 20, 2025 03:10

Fix(i18n): Update ESLint configuration to include jsonc-parser

6ad821d

Fix(i18n): Update ESLint file patterns and add 'components' to namesp…

a70a358

…aces

Fix(i18n): Initialize i18n(en) in DagCard tests

48fcb91

chore: enforce consistent array type syntax per @typescript-eslint rule

50267c3

Revert "chore: enforce consistent array type syntax per @typescript-e…

2010dcf

…slint rule" This reverts commit d218738.

Fix(i18n): Ignore i18n locale files in ESLint TypeScript rules

71cfb8d

Fix(tests): Remove unused imports and clean up test setup

fda512b

Apply pre-commit formatting to openapi-gen/ files as per apache#51755

0a0818e

Fix(eslint): Update i18n and TypeScript rules configuration

efb2a73

Apply ESLint and i18nRule

6376d32

choo121600 force-pushed the feature/i18n-http-backend branch from f7e3bba to 6376d32 Compare June 19, 2025 19:03

choo121600 requested review from hussein-awala and vincbeck as code owners June 19, 2025 19:03

choo121600 added 2 commits June 20, 2025 04:05

Mov Arabic and French translations to public

636cfcb

Fix: Update translation file paths to public directory

ee05571

Moved i18n doc and completeness checker script from public to dev/i18n

fea261a

choo121600 requested review from amoghrajesh and jedcunningham as code owners June 19, 2025 22:53

fix(i18n): i18n policy document translation completeness check command

f36856d

potiuk approved these changes Jun 20, 2025

View reviewed changes

potiuk merged commit b38e896 into apache:main Jun 20, 2025
98 checks passed

choo121600 deleted the feature/i18n-http-backend branch June 20, 2025 08:15

pierrejeambrun reviewed Jun 20, 2025

View reviewed changes

guan404ming mentioned this pull request Jun 20, 2025

i18n: add jsoncRules to handle translation key sort #51968

Merged

Conversation

choo121600 commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Before

After

Breaking Changes

Uh oh!

jscheffl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jscheffl commented Jun 14, 2025

Uh oh!

ashb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

choo121600 commented Jun 19, 2025

Uh oh!

choo121600 commented Jun 20, 2025

Uh oh!

choo121600 commented Jun 20, 2025

Uh oh!

potiuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

potiuk commented Jun 20, 2025

Uh oh!

choo121600 commented Jun 20, 2025

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

choo121600 commented Jun 14, 2025 •

edited

Loading