Make dag.test consistent with airflow dags test CLI command#51476
Merged
kaxil merged 2 commits intoapache:mainfrom Jun 6, 2025
Merged
Make dag.test consistent with airflow dags test CLI command#51476kaxil merged 2 commits intoapache:mainfrom
dag.test consistent with airflow dags test CLI command#51476kaxil merged 2 commits intoapache:mainfrom
Conversation
The only difference is CLI `airflow dags test` set logical date to current time, if not provided. While we default to `None` for dag.test. This was fine until but users using it for development of scheduled dags and using context will run into `KeyError: 'logical_date'` due to apache#48412
amoghrajesh
approved these changes
Jun 6, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
One comment to fix the CI, rest is good 👍🏽
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
2 tasks
This was referenced Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only difference is CLI
airflow dags testset logical date to current time, if not provided.While we default to
Nonefor dag.test. This was fine until but users using it for development of scheduled dags and using context will run intoKeyError: 'logical_date'due to #48412^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.