Implement slice on LazyXComSequence#50117
Merged
uranusjr merged 1 commit intoapache:mainfrom Jun 2, 2025
Merged
Conversation
ef91af5 to
6694e1a
Compare
6694e1a to
234e828
Compare
87d2547 to
7c366e1
Compare
7c366e1 to
509670c
Compare
amoghrajesh
reviewed
May 27, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Looking good, few comments
2 tasks
509670c to
7493e1f
Compare
amoghrajesh
reviewed
May 27, 2025
7493e1f to
0154964
Compare
amoghrajesh
reviewed
May 29, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Based on the code, we will not need the cadywn migration anymore if we plan to keep the old API as-is.
This is because:
- older client <=> new server will work as old API still works (no changes made there)
- newer client <=> new server will work as it will use new API
- newer client <=> old server is not a case we should be too worried about as its about forward compat, which is not of paramount importance as of now. We need to figure out task sdk, airflow core versioning even before that.
@uranusjr i think you can safely remove the cadwyn migration in this case.
kaxil
reviewed
May 29, 2025
kaxil
reviewed
May 29, 2025
Member
kaxil
left a comment
There was a problem hiding this comment.
1 comment needs addressing, rest lgtm
kaxil
approved these changes
May 29, 2025
sunank200
approved these changes
May 30, 2025
amoghrajesh
approved these changes
May 30, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM pending kaxil's comments and a simple test with old client, new server
d06ac9b to
c4418de
Compare
c4418de to
e87b4be
Compare
phanikumv
approved these changes
Jun 2, 2025
I decided to split index and slice access to their separate endpoints, instead of reusing the GetXCom endpoint. This duplicates code a bit, but the input parameters are now a lot easier to reason with. It's unfortunate FastAPI does not natively allow unions on Query(), or this could be implemented a lot nicer.
e87b4be to
84b36c4
Compare
amoghrajesh
approved these changes
Jun 2, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Yep this is good! Thanks!
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit f8abdcd)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit f8abdcd)
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #50011 (comment)
I decided to split index and slice access to their separate endpoints, instead of reusing the GetXCom endpoint. This duplicates code a bit, but the input parameters are now a lot easier to reason with. It's unfortunate FastAPI does not natively allow unions on Query(), or this could be implemented a lot nicer.